Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2860573008: Add more video capture log messages to WebRTC log (Closed)

Created:
3 years, 7 months ago by chfremer
Modified:
3 years, 7 months ago
Reviewers:
emircan
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more video capture log messages to WebRTC log Produce a WebRTC log message when: * starting to use gpu jpeg decoder * received first decoded frame from gpu jpeg decoder * gpu jpeg decoder fails * first frame received at VideoCaptureController BUG=717772 Review-Url: https://codereview.chromium.org/2860573008 Cr-Commit-Position: refs/heads/master@{#469220} Committed: https://chromium.googlesource.com/chromium/src/+/fc0be9a110adbda95a0367cdecafd46713fbcccb

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporate suggestions from PatchSet 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
chfremer
emircan@: PTAL
3 years, 7 months ago (2017-05-03 16:55:35 UTC) #4
emircan
lgtm % nit https://codereview.chromium.org/2860573008/diff/1/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h File content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h (right): https://codereview.chromium.org/2860573008/diff/1/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h#newcode46 content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h:46: explicit VideoCaptureGpuJpegDecoder( You don't need explicit ...
3 years, 7 months ago (2017-05-03 17:20:50 UTC) #5
chfremer
Thanks for the review! https://codereview.chromium.org/2860573008/diff/1/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h File content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h (right): https://codereview.chromium.org/2860573008/diff/1/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h#newcode46 content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h:46: explicit VideoCaptureGpuJpegDecoder( On 2017/05/03 17:20:50, ...
3 years, 7 months ago (2017-05-03 23:36:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860573008/20001
3 years, 7 months ago (2017-05-03 23:37:48 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 00:38:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc0be9a110adbda95a0367cdecaf...

Powered by Google App Engine
This is Rietveld 408576698