content/browser/renderer_host/media/video_capture_controller_unittest.cc - Issue 2860573008: Add more video capture log messages to WebRTC log

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_controller_unittest.cc

Issue 2860573008: Add more video capture log messages to WebRTC log (Closed)

Patch Set: Incorporate suggestions from PatchSet 1 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_controller.cc ('k') | content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_controller_unittest.cc

diff --git a/content/browser/renderer_host/media/video_capture_controller_unittest.cc b/content/browser/renderer_host/media/video_capture_controller_unittest.cc

index 162369f4d07f7c2bed6ee382d48dd59a0d767846..124f533df70316dc4d1023fb3018fb44b73297a1 100644

--- a/content/browser/renderer_host/media/video_capture_controller_unittest.cc

+++ b/content/browser/renderer_host/media/video_capture_controller_unittest.cc

@@ -47,8 +47,9 @@ using ::testing::SaveArg;

namespace content {

std::unique_ptr<media::VideoCaptureJpegDecoder> CreateGpuJpegDecoder(

- const media::VideoCaptureJpegDecoder::DecodeDoneCB& decode_done_cb) {

- return base::MakeUnique<content::VideoCaptureGpuJpegDecoder>(decode_done_cb);

+ media::VideoCaptureJpegDecoder::DecodeDoneCB decode_done_cb) {

+ return base::MakeUnique<content::VideoCaptureGpuJpegDecoder>(

+ std::move(decode_done_cb), base::Bind([](const std::string&) {}));

}

class MockVideoCaptureControllerEventHandler