chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java - Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor. (Closed)

Patch Set: review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeVisitor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

index 02c3e6a2f84dc710e640d3baef9172756ef5e2ca..9e859e6602404362257189e56916a614b8a87acc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

@@ -16,7 +16,6 @@ import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.ntp.ContextMenuManager;

import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder.PartialBindCallback;

import org.chromium.chrome.browser.ntp.snippets.SectionHeaderViewHolder;

-import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticleViewHolder;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

import org.chromium.chrome.browser.suggestions.SuggestionsRecyclerView;

@@ -292,11 +291,6 @@ public class NewTabPageAdapter extends Adapter<NewTabPageViewHolder> implements

}

@VisibleForTesting

- SnippetArticle getSuggestionAt(int position) {

- return mRoot.getSuggestionAt(position);

- }

- @VisibleForTesting

int getFirstPositionForType(@ItemViewType int viewType) {

int count = getItemCount();

for (int i = 0; i < count; i++) {