Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor. (Closed)
Patch Set: review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.ntp.cards; 5 package org.chromium.chrome.browser.ntp.cards;
6 6
7 import android.support.annotation.Nullable; 7 import android.support.annotation.Nullable;
8 import android.support.v7.widget.RecyclerView; 8 import android.support.v7.widget.RecyclerView;
9 import android.support.v7.widget.RecyclerView.Adapter; 9 import android.support.v7.widget.RecyclerView.Adapter;
10 import android.view.View; 10 import android.view.View;
11 import android.view.ViewGroup; 11 import android.view.ViewGroup;
12 12
13 import org.chromium.base.Callback; 13 import org.chromium.base.Callback;
14 import org.chromium.base.VisibleForTesting; 14 import org.chromium.base.VisibleForTesting;
15 import org.chromium.chrome.browser.ChromeFeatureList; 15 import org.chromium.chrome.browser.ChromeFeatureList;
16 import org.chromium.chrome.browser.ntp.ContextMenuManager; 16 import org.chromium.chrome.browser.ntp.ContextMenuManager;
17 import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder.PartialBindCal lback; 17 import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder.PartialBindCal lback;
18 import org.chromium.chrome.browser.ntp.snippets.SectionHeaderViewHolder; 18 import org.chromium.chrome.browser.ntp.snippets.SectionHeaderViewHolder;
19 import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;
20 import org.chromium.chrome.browser.ntp.snippets.SnippetArticleViewHolder; 19 import org.chromium.chrome.browser.ntp.snippets.SnippetArticleViewHolder;
21 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge; 20 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
22 import org.chromium.chrome.browser.suggestions.SuggestionsRecyclerView; 21 import org.chromium.chrome.browser.suggestions.SuggestionsRecyclerView;
23 import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate; 22 import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;
24 import org.chromium.chrome.browser.suggestions.TileGrid; 23 import org.chromium.chrome.browser.suggestions.TileGrid;
25 import org.chromium.chrome.browser.suggestions.TileGroup; 24 import org.chromium.chrome.browser.suggestions.TileGroup;
26 import org.chromium.chrome.browser.widget.displaystyle.UiConfig; 25 import org.chromium.chrome.browser.widget.displaystyle.UiConfig;
27 26
28 import java.util.List; 27 import java.util.List;
29 import java.util.Set; 28 import java.util.Set;
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 284
286 private boolean hasAllBeenDismissed() { 285 private boolean hasAllBeenDismissed() {
287 return mSections.isEmpty() && !mSigninPromo.isVisible(); 286 return mSections.isEmpty() && !mSigninPromo.isVisible();
288 } 287 }
289 288
290 private int getChildPositionOffset(TreeNode child) { 289 private int getChildPositionOffset(TreeNode child) {
291 return mRoot.getStartingOffsetForChild(child); 290 return mRoot.getStartingOffsetForChild(child);
292 } 291 }
293 292
294 @VisibleForTesting 293 @VisibleForTesting
295 SnippetArticle getSuggestionAt(int position) {
296 return mRoot.getSuggestionAt(position);
297 }
298
299 @VisibleForTesting
300 int getFirstPositionForType(@ItemViewType int viewType) { 294 int getFirstPositionForType(@ItemViewType int viewType) {
301 int count = getItemCount(); 295 int count = getItemCount();
302 for (int i = 0; i < count; i++) { 296 for (int i = 0; i < count; i++) {
303 if (getItemViewType(i) == viewType) return i; 297 if (getItemViewType(i) == viewType) return i;
304 } 298 }
305 return RecyclerView.NO_POSITION; 299 return RecyclerView.NO_POSITION;
306 } 300 }
307 301
308 SectionList getSectionListForTesting() { 302 SectionList getSectionListForTesting() {
309 return mSections; 303 return mSections;
310 } 304 }
311 305
312 InnerNode getRootForTesting() { 306 InnerNode getRootForTesting() {
313 return mRoot; 307 return mRoot;
314 } 308 }
315 } 309 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698