chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java - Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java

Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor. (Closed)

Patch Set: review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java

index 8ba3e9a05a180483444b1d1cfdaa8e08a3eae344..a1122e43f44d4567f4d32cd96fda40f87fffd9dc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java

@@ -5,7 +5,6 @@

package org.chromium.chrome.browser.ntp.cards;

import org.chromium.base.Callback;

-import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

import java.util.Collections;

import java.util.Set;

@@ -41,13 +40,6 @@ public abstract class Leaf extends ChildNode {

}

@Override

- public SnippetArticle getSuggestionAt(int position) {

- if (position != 0) throw new IndexOutOfBoundsException();

- return null;

- }

- @Override

public Set<Integer> getItemDismissalGroup(int position) {

return Collections.emptySet();

}