Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor. (Closed)
Patch Set: review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
index b80d30241162862d312e4bbae52bef3316b5d8e1..3052d0e240d427d2a9a9531591190b63ecb113bb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
@@ -9,7 +9,6 @@ import android.support.annotation.Nullable;
import org.chromium.base.Callback;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder.PartialBindCallback;
-import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;
import java.util.ArrayList;
import java.util.Collections;
@@ -84,13 +83,6 @@ public class InnerNode extends ChildNode implements NodeParent {
}
@Override
- public SnippetArticle getSuggestionAt(int position) {
- int index = getChildIndexForPosition(position);
- return mChildren.get(index).getSuggestionAt(
- position - getStartingOffsetForChildIndex(index));
- }
-
- @Override
public Set<Integer> getItemDismissalGroup(int position) {
int index = getChildIndexForPosition(position);
int offset = getStartingOffsetForChildIndex(index);
@@ -107,6 +99,13 @@ public class InnerNode extends ChildNode implements NodeParent {
}
@Override
+ public void visitItems(NodeVisitor visitor) {
+ for (TreeNode child : getChildren()) {
+ child.visitItems(visitor);
+ }
+ }
+
+ @Override
public void onItemRangeChanged(
TreeNode child, int index, int count, @Nullable PartialBindCallback callback) {
notifyItemRangeChanged(getStartingOffsetForChild(child) + index, count, callback);

Powered by Google App Engine
This is Rietveld 408576698