🔍 More SearchActivity tests

🔍 More SearchActivity tests

Fixes:
* Previously, typing in something before native finished loading
  didn't let autocomplete suggestions appear.

* Set OWNERS files with noparent so we're forced to review changes
  that could affect the search engine dialogs.

Tests:
* Adds a set of tests that monitors delays loading native and acts
  on the SearchActivity.

BUG=708844, 712833, 712836, 717327
Review-Url: https://codereview.chromium.org/2860313002
Cr-Commit-Position: refs/heads/master@{#469605}
Committed: https://chromium.googlesource.com/chromium/src/+/be19b0286e7a728f3f4f2bea96552959b900e923

[gone, 2017-05-05 00:58:28]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2017-05-05 01:35:18]

lgtm

https://codereview.chromium.org/2860313002/diff/1/chrome/android/javatests/sr...
File chrome/android/javatests/src/org/chromium/chrome/browser/locale/OWNERS
(right):

https://codereview.chromium.org/2860313002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/locale/OWNERS:1: set
noparent
For the test ones, you can set them to be references of the non-test ones

file://chrome/android/java/src/org/chromium/chrome/browser/locale/OWNERS

https://codereview.chromium.org/2860313002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java
(right):

https://codereview.chromium.org/2860313002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java:340:
CriteriaHelper.pollInstrumentationThread(new Criteria() {
Criteria.equals will get a nicer error message on failure

[gone, 2017-05-05 01:41:21]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 01:41:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 03:00:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 03:00:57]

Dry run: This issue passed the CQ dry run.

[gone, 2017-05-05 05:23:55]

https://codereview.chromium.org/2860313002/diff/1/chrome/android/javatests/sr...
File chrome/android/javatests/src/org/chromium/chrome/browser/locale/OWNERS
(right):

https://codereview.chromium.org/2860313002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/locale/OWNERS:1: set
noparent
On 2017/05/05 01:35:18, Ted C wrote:
> For the test ones, you can set them to be references of the non-test ones
> 
> file://chrome/android/java/src/org/chromium/chrome/browser/locale/OWNERS

Done.

https://codereview.chromium.org/2860313002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java
(right):

https://codereview.chromium.org/2860313002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java:340:
CriteriaHelper.pollInstrumentationThread(new Criteria() {
On 2017/05/05 01:35:18, Ted C wrote:
> Criteria.equals will get a nicer error message on failure

Done.

[gone, 2017-05-05 05:23:59]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-05-05 05:23:59]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2860313002/#ps20001
(title: "🔍 More SearchActivity tests")

[commit-bot: I haz the power, 2017-05-05 05:24:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 06:23:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493961839190930,
"parent_rev": "90a2c09a408cd07746ce7c4c260399dc985055ec", "commit_rev":
"be19b0286e7a728f3f4f2bea96552959b900e923"}

[commit-bot: I haz the power, 2017-05-05 06:24:14]

Description was changed from

==========
🔍 More SearchActivity tests

Fixes:
* Previously, typing in something before native finished loading
  didn't let autocomplete suggestions appear.

* Set OWNERS files with noparent so we're forced to review changes
  that could affect the search engine dialogs.

Tests:
* Adds a set of tests that monitors delays loading native and acts
  on the SearchActivity.

BUG=708844, 712833, 712836, 717327
==========

to

==========
🔍 More SearchActivity tests

Fixes:
* Previously, typing in something before native finished loading
  didn't let autocomplete suggestions appear.

* Set OWNERS files with noparent so we're forced to review changes
  that could affect the search engine dialogs.

Tests:
* Adds a set of tests that monitors delays loading native and acts
  on the SearchActivity.

BUG=708844, 712833, 712836, 717327

Review-Url: https://codereview.chromium.org/2860313002
Cr-Commit-Position: refs/heads/master@{#469605}
Committed:
https://chromium.googlesource.com/chromium/src/+/be19b0286e7a728f3f4f2bea9655...
==========

[commit-bot: I haz the power, 2017-05-05 06:24:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be19b0286e7a728f3f4f2bea9655...