Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2933)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java

Issue 2860313002: 🔍 More SearchActivity tests (Closed)
Patch Set: 🔍 More SearchActivity tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
index 0ee7f70062e74d4d4b8e6c66811e0844d91010ad..945d74d0a76016a4b9b5386329ed4c15d5d9e0ab 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
@@ -11,6 +11,7 @@ import android.support.annotation.Nullable;
import android.widget.Button;
import org.chromium.base.Callback;
+import org.chromium.base.VisibleForTesting;
import org.chromium.base.library_loader.LibraryLoader;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.locale.LocaleManager.SearchEnginePromoType;
@@ -20,6 +21,12 @@ import org.chromium.chrome.browser.widget.RadioButtonLayout;
/** A dialog that forces the user to choose a default search engine. */
public class DefaultSearchEnginePromoDialog extends PromoDialog {
+ /** Notified about events happening to the dialog. */
+ public static interface DefaultSearchEnginePromoDialogObserver {
+ void onDialogShown(DefaultSearchEnginePromoDialog shownDialog);
+ }
+ private static DefaultSearchEnginePromoDialogObserver sObserver;
+
/** Used to determine the promo dialog contents. */
@SearchEnginePromoType
private final int mDialogType;
@@ -83,6 +90,7 @@ public class DefaultSearchEnginePromoDialog extends PromoDialog {
okButton.setEnabled(false);
RadioButtonLayout radioButtons = new RadioButtonLayout(getContext());
+ radioButtons.setId(R.id.default_search_engine_dialog_options);
addControl(radioButtons);
Runnable dismissRunnable = new Runnable() {
@@ -96,6 +104,12 @@ public class DefaultSearchEnginePromoDialog extends PromoDialog {
}
@Override
+ public void show() {
+ super.show();
+ if (sObserver != null) sObserver.onDialogShown(this);
+ }
+
+ @Override
public void onDismiss(DialogInterface dialog) {
if (mHelper.getCurrentlySelectedKeyword() == null) {
// This shouldn't happen, but in case it does, finish the Activity so that the user has
@@ -107,4 +121,11 @@ public class DefaultSearchEnginePromoDialog extends PromoDialog {
mOnDismissed.onResult(mHelper.getCurrentlySelectedKeyword() != null);
}
}
+
+ /** See {@link #sObserver}. */
+ @VisibleForTesting
+ @Nullable
+ public static void setObserverForTests(DefaultSearchEnginePromoDialogObserver observer) {
+ sObserver = observer;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698