Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2860093002: Enable AutoDismissingDialogs by default. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
Nico, Ilya Sherman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable AutoDismissingDialogs by default. This allows them to be on for the continuous official Win builders. BUG=629964, 717947 Review-Url: https://codereview.chromium.org/2860093002 Cr-Commit-Position: refs/heads/master@{#469360} Committed: https://chromium.googlesource.com/chromium/src/+/69b6c44ab3317745f442a91b24b89e4e2f6ca20b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M chrome/common/chrome_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Avi (use Gerrit)
thakis@chromium.org: Please review changes in chrome/ isherman@chromium.org: Please review changes in testing/
3 years, 7 months ago (2017-05-04 15:21:01 UTC) #4
Nico
lgtm
3 years, 7 months ago (2017-05-04 15:30:57 UTC) #5
Ilya Sherman
lgtm
3 years, 7 months ago (2017-05-04 16:34:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860093002/1
3 years, 7 months ago (2017-05-04 16:34:33 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 16:44:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/69b6c44ab3317745f442a91b24b8...

Powered by Google App Engine
This is Rietveld 408576698