Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/common/chrome_features.cc

Issue 2860093002: Enable AutoDismissingDialogs by default. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | testing/variations/fieldtrial_testing_config.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_features.h" 5 #include "chrome/common/chrome_features.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 #include "extensions/features/features.h" 9 #include "extensions/features/features.h"
10 #include "ppapi/features/features.h" 10 #include "ppapi/features/features.h"
(...skipping 25 matching lines...) Expand all
36 #endif // defined(OS_CHROMEOS) 36 #endif // defined(OS_CHROMEOS)
37 37
38 // If enabled, the list of content suggestions on the New Tab page will contain 38 // If enabled, the list of content suggestions on the New Tab page will contain
39 // assets (e.g. books, pictures, audio) that the user downloaded for later use. 39 // assets (e.g. books, pictures, audio) that the user downloaded for later use.
40 const base::Feature kAssetDownloadSuggestionsFeature{ 40 const base::Feature kAssetDownloadSuggestionsFeature{
41 "NTPAssetDownloadSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; 41 "NTPAssetDownloadSuggestions", base::FEATURE_ENABLED_BY_DEFAULT};
42 42
43 #if !defined(OS_ANDROID) && !defined(OS_IOS) 43 #if !defined(OS_ANDROID) && !defined(OS_IOS)
44 // Enables auto-dismissing JavaScript dialogs. 44 // Enables auto-dismissing JavaScript dialogs.
45 const base::Feature kAutoDismissingDialogs{"AutoDismissingDialogs", 45 const base::Feature kAutoDismissingDialogs{"AutoDismissingDialogs",
46 base::FEATURE_DISABLED_BY_DEFAULT}; 46 base::FEATURE_ENABLED_BY_DEFAULT};
47 #endif 47 #endif
48 48
49 #if defined(OS_WIN) || defined(OS_MACOSX) 49 #if defined(OS_WIN) || defined(OS_MACOSX)
50 // Enables automatic tab discarding, when the system is in low memory state. 50 // Enables automatic tab discarding, when the system is in low memory state.
51 const base::Feature kAutomaticTabDiscarding{"AutomaticTabDiscarding", 51 const base::Feature kAutomaticTabDiscarding{"AutomaticTabDiscarding",
52 base::FEATURE_ENABLED_BY_DEFAULT}; 52 base::FEATURE_ENABLED_BY_DEFAULT};
53 #endif // defined(OS_WIN) || defined(OS_MACOSX) 53 #endif // defined(OS_WIN) || defined(OS_MACOSX)
54 54
55 #if defined(OS_WIN) || defined(OS_LINUX) 55 #if defined(OS_WIN) || defined(OS_LINUX)
56 // Enables the Restart background mode optimization. When all Chrome UI is 56 // Enables the Restart background mode optimization. When all Chrome UI is
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 return base::FeatureList::IsEnabled(features::kPrefService) || 346 return base::FeatureList::IsEnabled(features::kPrefService) ||
347 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) 347 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
348 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII( 348 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
349 switches::kMusConfig) == switches::kMash; 349 switches::kMusConfig) == switches::kMash;
350 #else 350 #else
351 false; 351 false;
352 #endif 352 #endif
353 } 353 }
354 354
355 } // namespace features 355 } // namespace features
OLDNEW
« no previous file with comments | « no previous file | testing/variations/fieldtrial_testing_config.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698