Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2860003002: supersize: Remove path attribution for symbol gaps (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Remove path attribution for symbol gaps The gaps have shown to move around, and so the blamed file is likely not really at fault. BUG=681694 Review-Url: https://codereview.chromium.org/2860003002 Cr-Commit-Position: refs/heads/master@{#469531} Committed: https://chromium.googlesource.com/chromium/src/+/6238cdf76fa491fdedd9501dfb7d60585fae6333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M tools/binary_size/libsupersize/linker_map_parser.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive.golden View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive_Elf.golden View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive_OutputDirectory.golden View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Console.golden View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/FullDescription.golden View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
agrieve
On 2017/05/04 19:54:22, agrieve wrote: > The CQ bit was checked by mailto:agrieve@chromium.org to run ...
3 years, 7 months ago (2017-05-04 19:54:32 UTC) #4
estevenson
On 2017/05/04 19:54:32, agrieve wrote: > On 2017/05/04 19:54:22, agrieve wrote: > > The CQ ...
3 years, 7 months ago (2017-05-04 20:06:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860003002/1
3 years, 7 months ago (2017-05-05 00:00:03 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 00:06:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6238cdf76fa491fdedd9501dfb7d...

Powered by Google App Engine
This is Rietveld 408576698