Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2856203004: supersize: Fix name normalization of top-level lambdas (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Fix name normalization of top-level lambdas Name: cc::{lambda(cc::PaintOp*)#63}::_FUN(cc::PaintOp*) Before: cc::{lambda After: cc::{lambda#63} This also tweaks Print() output to show # of unique symbols. BUG=681694 Review-Url: https://codereview.chromium.org/2856203004 Cr-Commit-Position: refs/heads/master@{#469070} Committed: https://chromium.googlesource.com/chromium/src/+/9a3f5f993acb59b16a6e1d5f157a46f6c7a11df8

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -14 lines) Patch
M tools/binary_size/libsupersize/describe.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/binary_size/libsupersize/function_signature.py View 3 chunks +23 lines, -4 lines 0 comments Download
M tools/binary_size/libsupersize/function_signature_test.py View 2 chunks +12 lines, -0 lines 0 comments Download
M tools/binary_size/libsupersize/models.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Console.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_Basic.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_NullDiff.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/FullDescription.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/SymbolGroupMethods.golden View 1 4 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
agrieve
On 2017/05/03 18:24:01, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🐜
3 years, 7 months ago (2017-05-03 18:24:07 UTC) #3
estevenson
On 2017/05/03 18:24:07, agrieve wrote: > On 2017/05/03 18:24:01, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
3 years, 7 months ago (2017-05-03 18:51:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856203004/1
3 years, 7 months ago (2017-05-03 18:58:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/260225) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 7 months ago (2017-05-03 19:03:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856203004/20001
3 years, 7 months ago (2017-05-03 19:10:37 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 19:26:20 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a3f5f993acb59b16a6e1d5f157a...

Powered by Google App Engine
This is Rietveld 408576698