Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2859933003: Revert of [regexp] Support unicode capture names in non-unicode patterns (Closed)

Created:
3 years, 7 months ago by Dan Ehrenberg
Modified:
3 years, 7 months ago
Reviewers:
Yang, jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Support unicode capture names in non-unicode patterns (patchset #3 id:40001 of https://codereview.chromium.org/2791163003/ ) Reason for revert: The decision for the specification was to not have this syntax, and instead the syntax before this patch. Original issue's description: > [regexp] Support unicode capture names in non-unicode patterns > > This ensures that capture names containing surrogate pairs are parsed > correctly even in non-unicode RegExp patterns by introducing a new > scanning mode which unconditionally combines surrogate pairs. > > BUG=v8:5437, v8:6192 > > Review-Url: https://codereview.chromium.org/2791163003 > Cr-Commit-Position: refs/heads/master@{#44466} > Committed: https://chromium.googlesource.com/v8/v8/+/a8651c5671dd6e41595ffb438e7ea013082f2d38 R=yangguo@chromium.org,jgruber@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5437, v8:6192 Review-Url: https://codereview.chromium.org/2859933003 Cr-Commit-Position: refs/heads/master@{#45088} Committed: https://chromium.googlesource.com/v8/v8/+/f918404590b6800c5a5ef26fb358abbc28622deb

Patch Set 1 #

Patch Set 2 : Fix conflict #

Patch Set 3 : Fixing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -29 lines) Patch
M src/regexp/regexp-parser.h View 1 2 chunks +4 lines, -10 lines 0 comments Download
M src/regexp/regexp-parser.cc View 1 7 chunks +13 lines, -17 lines 0 comments Download
M test/mjsunit/harmony/regexp-named-captures.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
Dan Ehrenberg
Created Revert of [regexp] Support unicode capture names in non-unicode patterns
3 years, 7 months ago (2017-05-04 09:12:40 UTC) #1
Dan Ehrenberg
Just to be sure, does it seem like a good plan to revert this patch?
3 years, 7 months ago (2017-05-04 11:07:07 UTC) #13
jgruber
On 2017/05/04 11:07:07, Dan Ehrenberg wrote: > Just to be sure, does it seem like ...
3 years, 7 months ago (2017-05-04 11:11:19 UTC) #16
jgruber
On 2017/05/04 11:11:19, jgruber wrote: > On 2017/05/04 11:07:07, Dan Ehrenberg wrote: > > Just ...
3 years, 7 months ago (2017-05-04 11:11:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859933003/120001
3 years, 7 months ago (2017-05-04 12:07:15 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 12:33:46 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/f918404590b6800c5a5ef26fb358abbc286...

Powered by Google App Engine
This is Rietveld 408576698