Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2791163003: [regexp] Support unicode capture names in non-unicode patterns (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 7 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Support unicode capture names in non-unicode patterns This ensures that capture names containing surrogate pairs are parsed correctly even in non-unicode RegExp patterns by introducing a new scanning mode which unconditionally combines surrogate pairs. BUG=v8:5437, v8:6192 Review-Url: https://codereview.chromium.org/2791163003 Cr-Commit-Position: refs/heads/master@{#44466} Committed: https://chromium.googlesource.com/v8/v8/+/a8651c5671dd6e41595ffb438e7ea013082f2d38

Patch Set 1 #

Patch Set 2 : Update test #

Total comments: 5

Patch Set 3 : Remove template parameter from ReadNext #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -20 lines) Patch
M src/regexp/regexp-parser.h View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
M src/regexp/regexp-parser.cc View 1 2 7 chunks +17 lines, -15 lines 0 comments Download
M test/mjsunit/harmony/regexp-named-captures.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (15 generated)
jgruber
3 years, 8 months ago (2017-04-03 11:38:59 UTC) #6
Yang
https://codereview.chromium.org/2791163003/diff/20001/src/regexp/regexp-parser.cc File src/regexp/regexp-parser.cc (left): https://codereview.chromium.org/2791163003/diff/20001/src/regexp/regexp-parser.cc#oldcode332 src/regexp/regexp-parser.cc:332: Advance(); How come we can remove this Advance here ...
3 years, 8 months ago (2017-04-05 12:52:39 UTC) #9
jgruber
https://codereview.chromium.org/2791163003/diff/20001/src/regexp/regexp-parser.cc File src/regexp/regexp-parser.cc (left): https://codereview.chromium.org/2791163003/diff/20001/src/regexp/regexp-parser.cc#oldcode332 src/regexp/regexp-parser.cc:332: Advance(); On 2017/04/05 12:52:38, Yang wrote: > How come ...
3 years, 8 months ago (2017-04-05 12:57:31 UTC) #10
Yang
On 2017/04/05 12:57:31, jgruber wrote: > https://codereview.chromium.org/2791163003/diff/20001/src/regexp/regexp-parser.cc > File src/regexp/regexp-parser.cc (left): > > https://codereview.chromium.org/2791163003/diff/20001/src/regexp/regexp-parser.cc#oldcode332 > ...
3 years, 8 months ago (2017-04-06 11:54:11 UTC) #11
jgruber
https://codereview.chromium.org/2791163003/diff/20001/src/regexp/regexp-parser.cc File src/regexp/regexp-parser.cc (right): https://codereview.chromium.org/2791163003/diff/20001/src/regexp/regexp-parser.cc#newcode49 src/regexp/regexp-parser.cc:49: template <bool update_position> On 2017/04/05 12:57:30, jgruber wrote: > ...
3 years, 8 months ago (2017-04-07 07:10:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791163003/40001
3 years, 8 months ago (2017-04-07 07:28:11 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/a8651c5671dd6e41595ffb438e7ea013082f2d38
3 years, 8 months ago (2017-04-07 07:34:18 UTC) #21
Dan Ehrenberg
In https://github.com/tc39/test262/pull/998#discussion_r113419975 , anba noticed that the named capture specification text actually doesn't support the ...
3 years, 7 months ago (2017-05-03 19:14:20 UTC) #23
jgruber
On 2017/05/03 19:14:20, Dan Ehrenberg wrote: > In https://github.com/tc39/test262/pull/998#discussion_r113419975 , anba noticed > that the ...
3 years, 7 months ago (2017-05-04 06:17:04 UTC) #24
Dan Ehrenberg
On 2017/05/04 06:17:04, jgruber wrote: > On 2017/05/03 19:14:20, Dan Ehrenberg wrote: > > In ...
3 years, 7 months ago (2017-05-04 09:11:31 UTC) #25
Dan Ehrenberg
3 years, 7 months ago (2017-05-04 09:12:40 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2859933003/ by littledan@chromium.org.

The reason for reverting is: The decision for the specification was to not have
this syntax, and instead the syntax before this patch..

Powered by Google App Engine
This is Rietveld 408576698