Reland "PaymentHandler: Implement PaymentInstruments.keys()."

Reland "PaymentHandler: Implement PaymentInstruments.keys()."

Reason for revert:
This patch is causing some PaymentManager tests to fail.
(https://crrev.com/2858773002)

Original issue's description:
> PaymentHandler: Implement PaymentInstruments.keys().
>
> The method to return keys of the stored payment instruments in insertion order.
>
> Related Spec Link:
>   https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface
>
> BUG=661608
> TEST=payment_manager_unittest.cc, payment-instruments.html
>
> Review-Url: https://codereview.chromium.org/2850203002
> Cr-Commit-Position: refs/heads/master@{#468747}
> Committed: https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0ecacc510e0be1d8

BUG=661608
Review-Url: https://codereview.chromium.org/2859803002
Cr-Commit-Position: refs/heads/master@{#469238}
Committed: https://chromium.googlesource.com/chromium/src/+/f7742a29c7b6832dbdf2336280d9fdf9fed6da4a

[zino, 2017-05-03 10:47:47]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 10:47:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 12:54:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 12:54:55]

Dry run: This issue passed the CQ dry run.

[zino, 2017-05-03 14:22:23]

Description was changed from

==========
Revert "Revert of PaymentHandler: Implement PaymentInstruments.keys(). (patchset
#3 id:40001 of https://codereview.chromium.org/2850203002/ )"

This reverts commit 9d3c221bdef03b02ef3ed0fe150433592d960f19.

BUG=
==========

to

==========
Reland "PaymentHandler: Implement PaymentInstruments.keys()."

Reason for revert:
This patch is causing some PaymentManager tests to fail.

Original issue's description:
> PaymentHandler: Implement PaymentInstruments.keys().
>
> The method to return keys of the stored payment instruments in insertion
order.
>
> Related Spec Link:
>  
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface
>
> BUG=661608
> TEST=payment_manager_unittest.cc, payment-instruments.html
>
> Review-Url: https://codereview.chromium.org/2850203002
> Cr-Commit-Position: refs/heads/master@{#468747}
> Committed:
https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0eca...

BUG=661608
==========

[zino, 2017-05-03 14:22:23]

jinho.bang@samsung.com changed reviewers:
+ nhiroki@chromium.org, rouslan@chromium.org, tsepez@chromium.org

[zino, 2017-05-03 14:23:56]

Description was changed from

==========
Reland "PaymentHandler: Implement PaymentInstruments.keys()."

Reason for revert:
This patch is causing some PaymentManager tests to fail.

Original issue's description:
> PaymentHandler: Implement PaymentInstruments.keys().
>
> The method to return keys of the stored payment instruments in insertion
order.
>
> Related Spec Link:
>  
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface
>
> BUG=661608
> TEST=payment_manager_unittest.cc, payment-instruments.html
>
> Review-Url: https://codereview.chromium.org/2850203002
> Cr-Commit-Position: refs/heads/master@{#468747}
> Committed:
https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0eca...

BUG=661608
==========

to

==========
Reland "PaymentHandler: Implement PaymentInstruments.keys()."

Reason for revert:
This patch is causing some PaymentManager tests to fail.
(https://crrev.com/2858773002)

Original issue's description:
> PaymentHandler: Implement PaymentInstruments.keys().
>
> The method to return keys of the stored payment instruments in insertion
order.
>
> Related Spec Link:
>  
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface
>
> BUG=661608
> TEST=payment_manager_unittest.cc, payment-instruments.html
>
> Review-Url: https://codereview.chromium.org/2850203002
> Cr-Commit-Position: refs/heads/master@{#468747}
> Committed:
https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0eca...

BUG=661608
==========

[zino, 2017-05-03 14:30:33]

PTAL.

https://codereview.chromium.org/2859803002/diff/20001/content/browser/payment...
File content/browser/payments/payment_app_database.cc (right):

https://codereview.chromium.org/2859803002/diff/20001/content/browser/payment...
content/browser/payments/payment_app_database.cc:497: bool success =
instrument_proto.SerializeToString(&serialized_instrument);
In the original CL, this line was in DCHECK as follows:
DCHECK(instrument_proto.SerializeToString(&serialized_instrument));

So, the statement wasn't executed in some bots disabling DCHECK.

https://codereview.chromium.org/2859803002/diff/20001/content/browser/payment...
content/browser/payments/payment_app_database.cc:505: success =
key_info_proto.SerializeToString(&serialized_key_info);
ditto

[please use gerrit instead, 2017-05-03 14:43:30]

lgtm

https://codereview.chromium.org/2859803002/diff/20001/content/browser/payment...
File content/browser/payments/payment_app_database.cc (right):

https://codereview.chromium.org/2859803002/diff/20001/content/browser/payment...
content/browser/payments/payment_app_database.cc:497: bool success =
instrument_proto.SerializeToString(&serialized_instrument);
On 2017/05/03 14:30:33, zino wrote:
> In the original CL, this line was in DCHECK as follows:
> DCHECK(instrument_proto.SerializeToString(&serialized_instrument));
> 
> So, the statement wasn't executed in some bots disabling DCHECK.

DCHECK is disabled in release mode (a.k.a., in production). Good catch!

[zino, 2017-05-03 15:37:32]

jinho.bang@samsung.com changed reviewers:
+ michaeln@chromium.org

[zino, 2017-05-03 15:40:42]

+michaeln@ for serviceworker/*

PTAL

This is a relanding patch.
I already got l-g-t-m from nhiroki@ in original CL.
(https://codereview.chromium.org/2850203002)
But he is OOO now.

Could you review this patch?

[Tom Sepez, 2017-05-03 16:10:23]

RS LGTM stampity stamp.

[michaeln, 2017-05-03 22:58:35]

r/s lgtm 2

[zino, 2017-05-03 23:28:06]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2017-05-03 23:28:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 01:32:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493854086071560,
"parent_rev": "2bb1cf11d22d50c5750d8d3b1356f0caa43d359e", "commit_rev":
"f7742a29c7b6832dbdf2336280d9fdf9fed6da4a"}

[commit-bot: I haz the power, 2017-05-04 01:40:02]

Description was changed from

==========
Reland "PaymentHandler: Implement PaymentInstruments.keys()."

Reason for revert:
This patch is causing some PaymentManager tests to fail.
(https://crrev.com/2858773002)

Original issue's description:
> PaymentHandler: Implement PaymentInstruments.keys().
>
> The method to return keys of the stored payment instruments in insertion
order.
>
> Related Spec Link:
>  
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface
>
> BUG=661608
> TEST=payment_manager_unittest.cc, payment-instruments.html
>
> Review-Url: https://codereview.chromium.org/2850203002
> Cr-Commit-Position: refs/heads/master@{#468747}
> Committed:
https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0eca...

BUG=661608
==========

to

==========
Reland "PaymentHandler: Implement PaymentInstruments.keys()."

Reason for revert:
This patch is causing some PaymentManager tests to fail.
(https://crrev.com/2858773002)

Original issue's description:
> PaymentHandler: Implement PaymentInstruments.keys().
>
> The method to return keys of the stored payment instruments in insertion
order.
>
> Related Spec Link:
>  
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface
>
> BUG=661608
> TEST=payment_manager_unittest.cc, payment-instruments.html
>
> Review-Url: https://codereview.chromium.org/2850203002
> Cr-Commit-Position: refs/heads/master@{#468747}
> Committed:
https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0eca...

BUG=661608

Review-Url: https://codereview.chromium.org/2859803002
Cr-Commit-Position: refs/heads/master@{#469238}
Committed:
https://chromium.googlesource.com/chromium/src/+/f7742a29c7b6832dbdf2336280d9...
==========

[commit-bot: I haz the power, 2017-05-04 01:40:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7742a29c7b6832dbdf2336280d9...

[brucedawson, 2017-05-17 21:50:00]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2017-05-17 21:50:01]

https://codereview.chromium.org/2859803002/diff/20001/content/browser/payment...
File content/browser/payments/payment_app_database.cc (right):

https://codereview.chromium.org/2859803002/diff/20001/content/browser/payment...
content/browser/payments/payment_app_database.cc:502:
key_info_proto.set_insertion_order(base::Time::Now().ToInternalValue());
I'm unclear about the purpose of this usage of base::Time::Now(), and I'm
concerned that it may cause errors. I suspect that it is intended to create a
monotonically increasing value, but on some Windows machines it is quite
possible for subsequent calls to base::Time::Now() to return the same value for
a time period up to about 16 ms in length. This may break assumptions and is
causing some tests to fail. Comments? See crbug.com/723225 for more context.