Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2859663003: [merge to M59] cros: Update rotation lock UI (Closed)

Created:
3 years, 7 months ago by Qiang(Joe) Xu
Modified:
3 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[merge to M59] cros: Update rotation lock UI changes: (1) When entering the tablet mode, the status area tray will always show the rotation lock auto or locked. (2) For system tray menu, the locked state is divided into two states: landscape and portrait. crbug.com/704923 #9 shows the UI implementation. TBR=oshima@chromium.org BUG=704923 TEST=tested on device Review-Url: https://codereview.chromium.org/2846883006 Cr-Commit-Position: refs/heads/master@{#468448} (cherry picked from commit 0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01) Review-Url: https://codereview.chromium.org/2859663003 . Cr-Commit-Position: refs/branch-heads/3071@{#363} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -283 lines) Patch
M ash/ash_strings.grd View 1 chunk +6 lines, -3 lines 0 comments Download
M ash/resources/vector_icons/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M ash/resources/vector_icons/system_menu_rotation_lock_auto.icon View 1 chunk +32 lines, -28 lines 0 comments Download
M ash/resources/vector_icons/system_menu_rotation_lock_auto.1x.icon View 1 chunk +32 lines, -28 lines 0 comments Download
A ash/resources/vector_icons/system_menu_rotation_lock_landscape.icon View 1 chunk +22 lines, -0 lines 0 comments Download
A ash/resources/vector_icons/system_menu_rotation_lock_landscape.1x.icon View 1 chunk +22 lines, -0 lines 0 comments Download
D ash/resources/vector_icons/system_menu_rotation_lock_locked.icon View 1 chunk +0 lines, -51 lines 0 comments Download
D ash/resources/vector_icons/system_menu_rotation_lock_locked.1x.icon View 1 chunk +0 lines, -52 lines 0 comments Download
A ash/resources/vector_icons/system_menu_rotation_lock_portrait.icon View 1 chunk +22 lines, -0 lines 0 comments Download
A ash/resources/vector_icons/system_menu_rotation_lock_portrait.1x.icon View 1 chunk +22 lines, -0 lines 0 comments Download
A ash/resources/vector_icons/system_tray_rotation_lock_auto.icon View 1 chunk +41 lines, -0 lines 0 comments Download
A ash/resources/vector_icons/system_tray_rotation_lock_auto.1x.icon View 1 chunk +41 lines, -0 lines 0 comments Download
M ash/resources/vector_icons/system_tray_rotation_lock_locked.icon View 1 chunk +41 lines, -41 lines 0 comments Download
M ash/resources/vector_icons/system_tray_rotation_lock_locked.1x.icon View 1 chunk +43 lines, -38 lines 0 comments Download
M ash/system/rotation/tray_rotation_lock.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ash/system/rotation/tray_rotation_lock.cc View 7 chunks +36 lines, -12 lines 0 comments Download
M ash/system/rotation/tray_rotation_lock_unittest.cc View 5 chunks +6 lines, -18 lines 0 comments Download
M ash/system/tray/tray_image_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/tray/tray_image_item.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M testing/buildbot/filters/ash_mus_unittests.filter View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
3 years, 7 months ago (2017-05-02 22:19:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698