cros: Update rotation lock UI

cros: Update rotation lock UI

changes:
(1) When entering the tablet mode, the status area tray will always show the rotation lock auto or locked.
(2) For system tray menu, the locked state is divided into two states: landscape and portrait.

crbug.com/704923 #9 shows the UI implementation.

BUG=704923
TEST=tested on device

Review-Url: https://codereview.chromium.org/2846883006
Cr-Commit-Position: refs/heads/master@{#468448}
Committed: https://chromium.googlesource.com/chromium/src/+/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01

[Qiang(Joe) Xu, 2017-04-28 03:59:40]

Description was changed from

==========
cros: Update rotation lock UI

BUG=704923
TEST=tested on device
==========

to

==========
cros: Update rotation lock UI

changes:
(1) When entering the tablet mode, the status area tray will always show the
rotation lock auto or locked.
(2) For system tray menu, the locked state is divided into two states: landscape
and portrait.

BUG=704923
TEST=tested on device
==========

[Qiang(Joe) Xu, 2017-04-28 03:59:40]

warx@chromium.org changed reviewers:
+ oshima@chromium.org

[Qiang(Joe) Xu, 2017-04-28 03:59:59]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 04:00:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2017-04-28 04:12:20]

Description was changed from

==========
cros: Update rotation lock UI

changes:
(1) When entering the tablet mode, the status area tray will always show the
rotation lock auto or locked.
(2) For system tray menu, the locked state is divided into two states: landscape
and portrait.

BUG=704923
TEST=tested on device
==========

to

==========
cros: Update rotation lock UI

changes:
(1) When entering the tablet mode, the status area tray will always show the
rotation lock auto or locked.
(2) For system tray menu, the locked state is divided into two states: landscape
and portrait.

crbug.com/704923 #9 shows the UI implementation.

BUG=704923
TEST=tested on device
==========

[Qiang(Joe) Xu, 2017-04-28 04:15:20]

oshima, PTAL, thanks!

I compared the worked SVG with non-working SVG. Found that the non-working SVG
missing the block <g fill="#000000"></g>.

[commit-bot: I haz the power, 2017-04-28 05:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:21:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Qiang(Joe) Xu, 2017-04-28 06:35:01]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 06:35:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 07:46:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 07:46:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2017-04-28 20:39:53]

lgtm

[Qiang(Joe) Xu, 2017-04-28 20:48:00]

On 2017/04/28 20:39:53, oshima wrote:
> lgtm

Thanks for review. I will hold on it for fixing yet another ash_mus_unittests
failure after gardening finished.

Also we need to clean up the tests as some of them are no longer meaningful,
like visibility check of 
CreateTrayViewDuringMaximizeModeAndRotationLock. It will always be visible in
maximize mode. But it can be cleaned in another CL.

[Qiang(Joe) Xu, 2017-05-01 20:29:46]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 20:30:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2017-05-01 21:46:03]

Hi oshima, please take another look, thanks!

Changes:
Removing a test case because the tray view is always visible on maximize mode no
matter of user rotation lock.

[oshima, 2017-05-01 21:54:33]

lgtm

[commit-bot: I haz the power, 2017-05-01 22:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 22:03:43]

Dry run: This issue passed the CQ dry run.

[Qiang(Joe) Xu, 2017-05-01 22:07:44]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-05-01 22:08:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 22:14:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493676464252720,
"parent_rev": "6794758842707fe09980d5495fed326413767a5f", "commit_rev":
"0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01"}

[commit-bot: I haz the power, 2017-05-01 22:14:35]

Description was changed from

==========
cros: Update rotation lock UI

changes:
(1) When entering the tablet mode, the status area tray will always show the
rotation lock auto or locked.
(2) For system tray menu, the locked state is divided into two states: landscape
and portrait.

crbug.com/704923 #9 shows the UI implementation.

BUG=704923
TEST=tested on device
==========

to

==========
cros: Update rotation lock UI

changes:
(1) When entering the tablet mode, the status area tray will always show the
rotation lock auto or locked.
(2) For system tray menu, the locked state is divided into two states: landscape
and portrait.

crbug.com/704923 #9 shows the UI implementation.

BUG=704923
TEST=tested on device

Review-Url: https://codereview.chromium.org/2846883006
Cr-Commit-Position: refs/heads/master@{#468448}
Committed:
https://chromium.googlesource.com/chromium/src/+/0eb3a02b096d72abc5f2f8f9ad6b...
==========

[commit-bot: I haz the power, 2017-05-01 22:14:36]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0eb3a02b096d72abc5f2f8f9ad6b...