Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2859503002: Revert of [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC. (Closed)

Created:
3 years, 7 months ago by michaeldo
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2810193004/ ) Reason for revert: Causes crashes of ios_chrome_integration_egtests, ios_chrome_settings_egtests, and ios_chrome_ui_egtests test suites. Ref: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/27109 Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Review-Url: https://codereview.chromium.org/2810193004 > Cr-Commit-Position: refs/heads/master@{#468634} > Committed: https://chromium.googlesource.com/chromium/src/+/ba4d7df1bcc063577dc66378f7465120fce5468a TBR=marq@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363 Review-Url: https://codereview.chromium.org/2859503002 Cr-Commit-Position: refs/heads/master@{#468664} Committed: https://chromium.googlesource.com/chromium/src/+/740ceaa120d7b3d03450bb801e59208a2a645cad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -239 lines) Patch
M ios/chrome/browser/ui/stack_view/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/stack_view/card_set.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_set.mm View 14 chunks +22 lines, -22 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_stack_layout_manager.h View 1 chunk +9 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/stack_view/card_stack_layout_manager.mm View 6 chunks +5 lines, -18 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_stack_pinch_gesture_recognizer.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/stack_view/card_view.mm View 20 chunks +34 lines, -36 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/close_button.mm View 2 chunks +1 line, -8 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/page_animation_util.mm View 4 chunks +7 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_card.mm View 3 chunks +9 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller.mm View 37 chunks +112 lines, -97 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller_private.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm View 3 chunks +7 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/title_label.mm View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
michaeldo
Created Revert of [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC.
3 years, 7 months ago (2017-05-02 16:13:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859503002/1
3 years, 7 months ago (2017-05-02 16:14:17 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:16:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/740ceaa120d7b3d03450bb801e59...

Powered by Google App Engine
This is Rietveld 408576698