Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2810193004: [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC. (Closed)

Created:
3 years, 8 months ago by stkhapugin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2810193004 Cr-Commit-Position: refs/heads/master@{#468634} Committed: https://chromium.googlesource.com/chromium/src/+/ba4d7df1bcc063577dc66378f7465120fce5468a

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 4

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -220 lines) Patch
M ios/chrome/browser/ui/stack_view/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_set.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_set.mm View 14 chunks +22 lines, -22 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_stack_layout_manager.h View 1 1 chunk +1 line, -9 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_stack_layout_manager.mm View 1 6 chunks +18 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_stack_pinch_gesture_recognizer.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/card_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/stack_view/card_view.mm View 1 20 chunks +36 lines, -34 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/close_button.mm View 1 2 chunks +8 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/stack_view/page_animation_util.mm View 4 chunks +8 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_card.mm View 1 3 chunks +11 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller.mm View 1 2 37 chunks +96 lines, -111 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller_private.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm View 3 chunks +11 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/title_label.mm View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
stkhapugin
PTAL
3 years, 8 months ago (2017-04-13 15:26:54 UTC) #4
marq (ping after 24h)
https://codereview.chromium.org/2810193004/diff/20001/ios/chrome/browser/ui/stack_view/stack_view_controller.mm File ios/chrome/browser/ui/stack_view/stack_view_controller.mm (right): https://codereview.chromium.org/2810193004/diff/20001/ios/chrome/browser/ui/stack_view/stack_view_controller.mm#newcode454 ios/chrome/browser/ui/stack_view/stack_view_controller.mm:454: CardSet* __weak _activeCardSet; // weak Please be consistent with ...
3 years, 8 months ago (2017-04-13 17:17:28 UTC) #5
stkhapugin
Thanks, PTAL https://codereview.chromium.org/2810193004/diff/20001/ios/chrome/browser/ui/stack_view/stack_view_controller.mm File ios/chrome/browser/ui/stack_view/stack_view_controller.mm (right): https://codereview.chromium.org/2810193004/diff/20001/ios/chrome/browser/ui/stack_view/stack_view_controller.mm#newcode454 ios/chrome/browser/ui/stack_view/stack_view_controller.mm:454: CardSet* __weak _activeCardSet; // weak On 2017/04/13 ...
3 years, 8 months ago (2017-04-14 09:44:29 UTC) #6
stkhapugin
Thanks, PTAL https://codereview.chromium.org/2810193004/diff/20001/ios/chrome/browser/ui/stack_view/stack_view_controller.mm File ios/chrome/browser/ui/stack_view/stack_view_controller.mm (right): https://codereview.chromium.org/2810193004/diff/20001/ios/chrome/browser/ui/stack_view/stack_view_controller.mm#newcode454 ios/chrome/browser/ui/stack_view/stack_view_controller.mm:454: CardSet* __weak _activeCardSet; // weak On 2017/04/13 ...
3 years, 8 months ago (2017-04-14 09:44:30 UTC) #7
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-14 10:17:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810193004/40001
3 years, 7 months ago (2017-05-02 13:50:18 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ba4d7df1bcc063577dc66378f7465120fce5468a
3 years, 7 months ago (2017-05-02 14:59:58 UTC) #15
michaeldo
3 years, 7 months ago (2017-05-02 16:13:51 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2859503002/ by michaeldo@chromium.org.

The reason for reverting is: Causes crashes of ios_chrome_integration_egtests,
ios_chrome_settings_egtests, and ios_chrome_ui_egtests test suites. Ref:
https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/27109.

Powered by Google App Engine
This is Rietveld 408576698