Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2859483004: Revert of Don't pass subpixel offsets through non-translation transforms (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't pass subpixel offsets through non-translation transforms (patchset #7 id:120001 of https://codereview.chromium.org/2847873002/ ) Reason for revert: BUG=717882 Original issue's description: > Don't pass subpixel offsets through non-translation transforms > > Non-translation transforms will change direction and/or scale, etc. > of offsets thus making subpixel accumulation through the transform > meaningless. > > This CL addresses the issue in PaintLayerPainter and > PaintPropertyTreeBuilder. We still need to address the issue in > CompositedLayerMapping (crbug.com/716163). > > BUG=710665 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2847873002 > Cr-Commit-Position: refs/heads/master@{#468516} > Committed: https://chromium.googlesource.com/chromium/src/+/098430b33423191b06dc32f13de764076cf60394 TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=710665 Review-Url: https://codereview.chromium.org/2859483004 Cr-Commit-Position: refs/heads/master@{#469054} Committed: https://chromium.googlesource.com/chromium/src/+/763e91015ba203feaa3b27c77ce4aa52638ec6e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -209 lines) Patch
M third_party/WebKit/LayoutTests/fast/sub-pixel/sub-pixel-root-layer.html View 2 chunks +4 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/shadows/shadow-drawing-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/selection/transformed-selection-rects-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/transforms/svg-css-transforms-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/transforms/svg-vs-css-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/reflection-repaint-test-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/transform-layout-repaint-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/shadows/shadow-drawing-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.11/svg/transforms/svg-css-transforms-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.11/transforms/svg-vs-css-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/svg/transforms/svg-css-transforms-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/transforms/svg-vs-css-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/compositing/shadows/shadow-drawing-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/transforms/svg-css-transforms-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/transforms/svg-vs-css-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/transforms/transform-on-inline-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/shadows/shadow-drawing-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/transforms/svg-css-transforms-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/transforms/svg-vs-css-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/reflection-repaint-test-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/transform-layout-repaint-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/compositing/shadows/shadow-drawing-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/invalidation-with-scale-transform-expected.txt View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 3 chunks +29 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +9 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Xianzhu
Created Revert of Don't pass subpixel offsets through non-translation transforms
3 years, 7 months ago (2017-05-03 15:41:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859483004/1
3 years, 7 months ago (2017-05-03 15:42:21 UTC) #3
chrishtr
Why is it not just that chrome://md-settings is wrong and needs adjustment? It sounds like ...
3 years, 7 months ago (2017-05-03 16:46:27 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/444354)
3 years, 7 months ago (2017-05-03 17:41:01 UTC) #6
Xianzhu
On 2017/05/03 16:46:27, chrishtr wrote: > Why is it not just that chrome://md-settings is wrong ...
3 years, 7 months ago (2017-05-03 17:43:26 UTC) #7
Xianzhu
On 2017/05/03 17:43:26, Xianzhu wrote: > On 2017/05/03 16:46:27, chrishtr wrote: > > Why is ...
3 years, 7 months ago (2017-05-03 18:18:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859483004/1
3 years, 7 months ago (2017-05-03 18:19:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/763e91015ba203feaa3b27c77ce4aa52638ec6e4
3 years, 7 months ago (2017-05-03 18:54:53 UTC) #13
Xianzhu
3 years, 7 months ago (2017-05-04 18:33:38 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2862053002/ by wangxianzhu@chromium.org.

The reason for reverting is: Just to create a CL for the base of relanding..

Powered by Google App Engine
This is Rietveld 408576698