Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/444354)
3 years, 7 months ago
(2017-05-03 17:41:01 UTC)
#6
On 2017/05/03 16:46:27, chrishtr wrote: > Why is it not just that chrome://md-settings is wrong ...
3 years, 7 months ago
(2017-05-03 17:43:26 UTC)
#7
On 2017/05/03 16:46:27, chrishtr wrote:
> Why is it not just that chrome://md-settings is wrong and needs adjustment?
> It sounds like that page just relies on behavior that should change.
I'm reducing the case to see if the page's expectation is reasonable.
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
3 years, 7 months ago
(2017-05-03 18:18:17 UTC)
#8
On 2017/05/03 17:43:26, Xianzhu wrote: > On 2017/05/03 16:46:27, chrishtr wrote: > > Why is ...
3 years, 7 months ago
(2017-05-03 18:18:53 UTC)
#9
On 2017/05/03 17:43:26, Xianzhu wrote:
> On 2017/05/03 16:46:27, chrishtr wrote:
> > Why is it not just that chrome://md-settings is wrong and needs adjustment?
> > It sounds like that page just relies on behavior that should change.
>
> I'm reducing the case to see if the page's expectation is reasonable.
Please see crbug.com/716163 for any updates.
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859483004/1
3 years, 7 months ago
(2017-05-03 18:19:31 UTC)
#10
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1493835497878290, "parent_rev": "e16cd1440c94c183b042fdd1c38a76138878a17b", "commit_rev": "763e91015ba203feaa3b27c77ce4aa52638ec6e4"}
3 years, 7 months ago
(2017-05-03 18:54:15 UTC)
#11
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493835497878290, "parent_rev":
"e16cd1440c94c183b042fdd1c38a76138878a17b", "commit_rev":
"763e91015ba203feaa3b27c77ce4aa52638ec6e4"}
commit-bot: I haz the power
Description was changed from ========== Revert of Don't pass subpixel offsets through non-translation transforms (patchset ...
3 years, 7 months ago
(2017-05-03 18:54:52 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
Revert of Don't pass subpixel offsets through non-translation transforms
(patchset #7 id:120001 of https://codereview.chromium.org/2847873002/ )
Reason for revert:
BUG=717882
Original issue's description:
> Don't pass subpixel offsets through non-translation transforms
>
> Non-translation transforms will change direction and/or scale, etc.
> of offsets thus making subpixel accumulation through the transform
> meaningless.
>
> This CL addresses the issue in PaintLayerPainter and
> PaintPropertyTreeBuilder. We still need to address the issue in
> CompositedLayerMapping (crbug.com/716163).
>
> BUG=710665
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2847873002
> Cr-Commit-Position: refs/heads/master@{#468516}
> Committed:
https://chromium.googlesource.com/chromium/src/+/098430b33423191b06dc32f13de7...TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=710665
==========
to
==========
Revert of Don't pass subpixel offsets through non-translation transforms
(patchset #7 id:120001 of https://codereview.chromium.org/2847873002/ )
Reason for revert:
BUG=717882
Original issue's description:
> Don't pass subpixel offsets through non-translation transforms
>
> Non-translation transforms will change direction and/or scale, etc.
> of offsets thus making subpixel accumulation through the transform
> meaningless.
>
> This CL addresses the issue in PaintLayerPainter and
> PaintPropertyTreeBuilder. We still need to address the issue in
> CompositedLayerMapping (crbug.com/716163).
>
> BUG=710665
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2847873002
> Cr-Commit-Position: refs/heads/master@{#468516}
> Committed:
https://chromium.googlesource.com/chromium/src/+/098430b33423191b06dc32f13de7...TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=710665
Review-Url: https://codereview.chromium.org/2859483004
Cr-Commit-Position: refs/heads/master@{#469054}
Committed:
https://chromium.googlesource.com/chromium/src/+/763e91015ba203feaa3b27c77ce4...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/763e91015ba203feaa3b27c77ce4aa52638ec6e4
3 years, 7 months ago
(2017-05-03 18:54:53 UTC)
#13
Issue 2859483004: Revert of Don't pass subpixel offsets through non-translation transforms
(Closed)
Created 3 years, 7 months ago by Xianzhu
Modified 3 years, 7 months ago
Reviewers: chrishtr
Base URL:
Comments: 0