[ios clean] Adds Progress Bar to Toolbar.

[ios clean] Adds Progress Bar to Toolbar.

Also some small cleaning up/refactoring.

Screenshot:
https://drive.google.com/open?id=0Byo6-Nuda2jgVE9McFdRLVgtVkk

BUG=683793
Review-Url: https://codereview.chromium.org/2859363002
Cr-Commit-Position: refs/heads/master@{#470572}
Committed: https://chromium.googlesource.com/chromium/src/+/b0222f5f67d4edb059c7ca478a8349e12f6943de

[sczs, 2017-05-05 00:32:26]

Description was changed from

==========
[ios clean] Adds Progress Bar to Toolbar.



BUG=683793
==========

to

==========
[ios clean] Adds Progress Bar to Toolbar.

Also some small cleaning up/refactoring.

Screenshot:
https://drive.google.com/open?id=0Byo6-Nuda2jgVE9McFdRLVgtVkk

BUG=683793
==========

[sczs, 2017-05-05 00:32:27]

sczs@chromium.org changed reviewers:
+ edchin@chromium.org, lpromero@chromium.org, marq@chromium.org

[sczs, 2017-05-05 00:44:18]

Hi Louis PTAL if you have time, if not we can wait for Mark and/or Ed to come
back next week.

[lpromero, 2017-05-05 14:43:52]

lgtm if the intent is to have a PLACEHOLDER version

https://codereview.chromium.org/2859363002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm (right):

https://codereview.chromium.org/2859363002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm:39:
@property(nonatomic, strong) UIProgressView* progressBar;
Why not an MDCProgressView like the current app?

https://codereview.chromium.org/2859363002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm:275:
self.progressBar.hidden = YES;
MDCProgressView allows you to animate the progress and hidden state changes.
These are not present in this CL. Is it a PLACEHOLDER progress view?

[sczs, 2017-05-05 23:15:45]

Took care of the feedback and updated the unittests. PTAL

https://codereview.chromium.org/2859363002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm (right):

https://codereview.chromium.org/2859363002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm:39:
@property(nonatomic, strong) UIProgressView* progressBar;
On 2017/05/05 14:43:51, lpromero wrote:
> Why not an MDCProgressView like the current app?

You're right, I've should've used that in the first place. 
Done.

https://codereview.chromium.org/2859363002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm:275:
self.progressBar.hidden = YES;
On 2017/05/05 14:43:51, lpromero wrote:
> MDCProgressView allows you to animate the progress and hidden state changes.
> These are not present in this CL. Is it a PLACEHOLDER progress view?

Didn't intend this to be a PLACEHOLDER. Switched to MDCProgressView.

https://codereview.chromium.org/2859363002/diff/20001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/toolbar/toolbar_mediator_unittest.mm (right):

https://codereview.chromium.org/2859363002/diff/20001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/toolbar/toolbar_mediator_unittest.mm:135: [mediator_
webState:mediator_.webState didChangeLoadingProgress:0.42];
I've tried to trigger this by opening a URL with the testwebstate but its not
working. Will ask around or will keep digging to find a better way to do it. In
any case I want to send this CL so PAR can get an overall look on Monday. 

Any ideas are welcome :)

[marq (ping after 24h), 2017-05-09 12:07:31]

lgtm

https://codereview.chromium.org/2859363002/diff/20001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/toolbar/toolbar_mediator_unittest.mm (right):

https://codereview.chromium.org/2859363002/diff/20001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/toolbar/toolbar_mediator_unittest.mm:135: [mediator_
webState:mediator_.webState didChangeLoadingProgress:0.42];
On 2017/05/05 23:15:45, sczs wrote:
> I've tried to trigger this by opening a URL with the testwebstate but its not
> working. Will ask around or will keep digging to find a better way to do it.
In
> any case I want to send this CL so PAR can get an overall look on Monday. 
> 
> Any ideas are welcome :) 

I don't think you'll get any loading progress updates from anything that's not
loading a live WebState. While this isn't ideal, I think it's a reasonable
compromise for now.

[sczs, 2017-05-09 17:06:38]

The CQ bit was checked by sczs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 17:07:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 23:12:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 23:12:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sczs, 2017-05-10 01:56:35]

The CQ bit was checked by sczs@chromium.org

[sczs, 2017-05-10 01:56:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2859363002/#ps20001
(title: "Uses MDCProgressView and adds unittest.")

[commit-bot: I haz the power, 2017-05-10 01:57:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:00:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[sczs, 2017-05-10 14:46:48]

The CQ bit was checked by sczs@chromium.org

[commit-bot: I haz the power, 2017-05-10 14:47:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 14:55:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494427608505270,
"parent_rev": "0c70f4f12d5c4960f3938f330c860d109da4b984", "commit_rev":
"b0222f5f67d4edb059c7ca478a8349e12f6943de"}

[commit-bot: I haz the power, 2017-05-10 14:55:41]

Description was changed from

==========
[ios clean] Adds Progress Bar to Toolbar.

Also some small cleaning up/refactoring.

Screenshot:
https://drive.google.com/open?id=0Byo6-Nuda2jgVE9McFdRLVgtVkk

BUG=683793
==========

to

==========
[ios clean] Adds Progress Bar to Toolbar.

Also some small cleaning up/refactoring.

Screenshot:
https://drive.google.com/open?id=0Byo6-Nuda2jgVE9McFdRLVgtVkk

BUG=683793

Review-Url: https://codereview.chromium.org/2859363002
Cr-Commit-Position: refs/heads/master@{#470572}
Committed:
https://chromium.googlesource.com/chromium/src/+/b0222f5f67d4edb059c7ca478a83...
==========

[commit-bot: I haz the power, 2017-05-10 14:55:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b0222f5f67d4edb059c7ca478a83...