[ios clean] Adds Progress Bar to Toolbar.

ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h"
 
 #import "base/mac/foundation_util.h"
 #import "ios/clean/chrome/browser/ui/actions/tab_strip_actions.h"
 #import "ios/clean/chrome/browser/ui/commands/navigation_commands.h"
 #import "ios/clean/chrome/browser/ui/commands/tab_grid_commands.h"
 #import "ios/clean/chrome/browser/ui/commands/tools_menu_commands.h"
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.h"
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_component_options.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 namespace {
 // Stackview Vertical Margin.
 CGFloat kVerticalMargin = 5.0f;
 // Stackview Horizontal Margin.
 CGFloat kHorizontalMargin = 8.0f;
+// Progress Bar Height.
+CGFloat kProgressBarHeight = 2.0f;
 }  // namespace
 
 @interface ToolbarViewController ()
 @property(nonatomic, strong) UIView* locationBarContainer;
 @property(nonatomic, strong) UIStackView* stackView;
 @property(nonatomic, strong) ToolbarButton* backButton;
 @property(nonatomic, strong) ToolbarButton* forwardButton;
 @property(nonatomic, strong) ToolbarButton* tabSwitchStripButton;
 @property(nonatomic, strong) ToolbarButton* tabSwitchGridButton;
 @property(nonatomic, strong) ToolbarButton* toolsMenuButton;
 @property(nonatomic, strong) ToolbarButton* shareButton;
 @property(nonatomic, strong) ToolbarButton* reloadButton;
 @property(nonatomic, strong) ToolbarButton* stopButton;
+@property(nonatomic, strong) UIProgressView* progressBar;

[lpromero, 2017/05/05 14:43:51]

Why not an MDCProgressView like the current app?

[sczs, 2017/05/05 23:15:45]

You're right, I've should've used that in the first place. 
Done.

 @end
 
 @implementation ToolbarViewController
 @synthesize dispatcher = _dispatcher;
 @synthesize locationBarViewController = _locationBarViewController;
 @synthesize stackView = _stackView;
 @synthesize locationBarContainer = _locationBarContainer;
 @synthesize backButton = _backButton;
 @synthesize forwardButton = _forwardButton;
 @synthesize tabSwitchStripButton = _tabSwitchStripButton;
 @synthesize tabSwitchGridButton = _tabSwitchGridButton;
 @synthesize toolsMenuButton = _toolsMenuButton;
 @synthesize shareButton = _shareButton;
 @synthesize reloadButton = _reloadButton;
 @synthesize stopButton = _stopButton;
+@synthesize progressBar = _progressBar;
 
 - (instancetype)init {
   self = [super init];
   if (self) {
     [self setUpToolbarButtons];
     [self setUpLocationBarContainer];
+    [self setUpProgressBar];
   }
   return self;
 }
 
 - (void)viewDidLoad {
   self.view.backgroundColor = [UIColor lightGrayColor];
-
   [self addChildViewController:self.locationBarViewController
                      toSubview:self.locationBarContainer];
+  [self setUpToolbarStackView];
+  [self.view addSubview:self.stackView];
+  [self.view addSubview:self.progressBar];
+  [self setConstraints];
+}
 
-  // Stack view to contain toolbar items.
+#pragma mark - View Setup
+
+// Sets up the StackView that contains toolbar navigation items.
+- (void)setUpToolbarStackView {
   self.stackView = [[UIStackView alloc] initWithArrangedSubviews:@[
     self.backButton, self.forwardButton, self.reloadButton, self.stopButton,
     self.locationBarContainer, self.shareButton, self.tabSwitchStripButton,
     self.tabSwitchGridButton, self.toolsMenuButton
   ]];
-  [self updateAllButtonsVisibility];
   self.stackView.translatesAutoresizingMaskIntoConstraints = NO;
   self.stackView.spacing = 16.0;
   self.stackView.distribution = UIStackViewDistributionFill;
-  [self.view addSubview:self.stackView];
+  [self updateAllButtonsVisibility];
+}
 
-  // Set constraints.
+- (void)setConstraints {
   [self.view setAutoresizingMask:UIViewAutoresizingFlexibleWidth |
                                  UIViewAutoresizingFlexibleHeight];
   [NSLayoutConstraint activateConstraints:@[
     [self.stackView.topAnchor constraintEqualToAnchor:self.view.topAnchor
                                              constant:kVerticalMargin],
     [self.stackView.bottomAnchor constraintEqualToAnchor:self.view.bottomAnchor
                                                 constant:-kVerticalMargin],
     [self.stackView.leadingAnchor
         constraintEqualToAnchor:self.view.leadingAnchor
                        constant:kHorizontalMargin],
     [self.stackView.trailingAnchor
         constraintEqualToAnchor:self.view.trailingAnchor
                        constant:-kHorizontalMargin],
+    [self.progressBar.leadingAnchor
+        constraintEqualToAnchor:self.view.leadingAnchor],
+    [self.progressBar.trailingAnchor
+        constraintEqualToAnchor:self.view.trailingAnchor],
+    [self.progressBar.bottomAnchor
+        constraintEqualToAnchor:self.view.bottomAnchor],
+    [self.progressBar.heightAnchor
+        constraintEqualToConstant:kProgressBarHeight],
   ]];
 }
 
 #pragma mark - Components Setup
 
 - (void)setUpToolbarButtons {
   // Back button.
   self.backButton = [ToolbarButton backToolbarButton];
   self.backButton.visibilityMask = ToolbarComponentVisibilityCompactWidth |
                                    ToolbarComponentVisibilityRegularWidth;
@@ skipping 62 matching lines @@
 - (void)setUpLocationBarContainer {
   UIView* locationBarContainer = [[UIView alloc] initWithFrame:CGRectZero];
   locationBarContainer.translatesAutoresizingMaskIntoConstraints = NO;
   locationBarContainer.backgroundColor = [UIColor whiteColor];
   [locationBarContainer
       setContentHuggingPriority:UILayoutPriorityDefaultLow
                         forAxis:UILayoutConstraintAxisHorizontal];
   self.locationBarContainer = locationBarContainer;
 }
 
+- (void)setUpProgressBar {
+  UIProgressView* progressBar =
+      [[UIProgressView alloc] initWithFrame:CGRectZero];
+  progressBar.translatesAutoresizingMaskIntoConstraints = NO;
+  self.progressBar = progressBar;
+}
+
 #pragma mark - View Controller Containment
 
 - (void)addChildViewController:(UIViewController*)viewController
                      toSubview:(UIView*)subview {
   if (!viewController || !subview) {
     return;
   }
   [self addChildViewController:viewController];
   viewController.view.translatesAutoresizingMaskIntoConstraints = YES;
   viewController.view.autoresizingMask =
@@ skipping 33 matching lines @@
       if ([view isKindOfClass:[ToolbarButton class]]) {
         ToolbarButton* button = base::mac::ObjCCastStrict<ToolbarButton>(view);
         [button updateHiddenInCurrentSizeClass];
       }
     }
   }
 }
 
 #pragma mark - ToolbarWebStateConsumer
 
-- (void)setCurrentPageText:(NSString*)text {
-}
-
 - (void)setCanGoForward:(BOOL)canGoForward {
   self.forwardButton.enabled = canGoForward;
   // Update the visibility since the Forward button will be hidden on
   // CompactWidth when disabled.
   [self.forwardButton updateHiddenInCurrentSizeClass];
 }
 
 - (void)setCanGoBack:(BOOL)canGoBack {
   self.backButton.enabled = canGoBack;
 }
 
 - (void)setIsLoading:(BOOL)isLoading {
   self.reloadButton.hiddenInCurrentState = isLoading;
   self.stopButton.hiddenInCurrentState = !isLoading;
   [self updateAllButtonsVisibility];
 }
 
+- (void)setProgress:(double)progress {
+  if (progress == 0 || progress == 1.0) {
+    self.progressBar.hidden = YES;

[lpromero, 2017/05/05 14:43:51]

MDCProgressView allows you to animate the progress and hidden state changes.
These are not present in this CL. Is it a PLACEHOLDER progress view?

[sczs, 2017/05/05 23:15:45]

Didn't intend this to be a PLACEHOLDER. Switched to MDCProgressView.

+    return;
+  }
+  self.progressBar.hidden = NO;
+  self.progressBar.progress = progress;
+}
+
 #pragma mark - ZoomTransitionDelegate
 
 - (CGRect)rectForZoomWithKey:(NSObject*)key inView:(UIView*)view {
   return [view convertRect:self.toolsMenuButton.bounds
                   fromView:self.toolsMenuButton];
 }
 
 #pragma mark - Private Methods
 
 - (void)showToolsMenu:(id)sender {
@@ skipping 48 matching lines @@
 - (void)updateAllButtonsVisibility {
   for (UIView* view in self.stackView.arrangedSubviews) {
     if ([view isKindOfClass:[ToolbarButton class]]) {
       ToolbarButton* button = base::mac::ObjCCastStrict<ToolbarButton>(view);
       [button setHiddenForCurrentStateAndSizeClass];
     }
   }
 }
 
 @end