components/autofill/content/renderer/password_autofill_agent.h - Issue 2859243004: Add metrics for PasswordForm submission types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 2859243004: Add metrics for PasswordForm submission types (Closed)

Patch Set: addressed reviewer comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index 76f9fa0979cc4a8956d3d59e2f392d7adbd75b82..b8f80e7f3807e64e90c32cc3fe552f6ac1fa63d0 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -258,7 +258,7 @@ class PasswordAutofillAgent : public content::RenderFrameObserver,

ProvisionallySaveRestriction restriction);

// Helper function called when same-document navigation completed

- void OnSameDocumentNavigationCompleted();

+ void OnSameDocumentNavigationCompleted(bool is_inpage_navigation);

const mojom::AutofillDriverPtr& GetAutofillDriver();