Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 2859243004: Add metrics for PasswordForm submission types (Closed)
Patch Set: addressed reviewer comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <vector> 10 #include <vector>
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 // user has just been interacting with before the form save. |form| or |input| 251 // user has just been interacting with before the form save. |form| or |input|
252 // can be null but not both at the same time. For example: if the form is 252 // can be null but not both at the same time. For example: if the form is
253 // unowned, |form| will be null; if the user has submitted the form, |input| 253 // unowned, |form| will be null; if the user has submitted the form, |input|
254 // will be null. 254 // will be null.
255 void ProvisionallySavePassword(std::unique_ptr<PasswordForm> password_form, 255 void ProvisionallySavePassword(std::unique_ptr<PasswordForm> password_form,
256 const blink::WebFormElement& form, 256 const blink::WebFormElement& form,
257 const blink::WebInputElement& input, 257 const blink::WebInputElement& input,
258 ProvisionallySaveRestriction restriction); 258 ProvisionallySaveRestriction restriction);
259 259
260 // Helper function called when same-document navigation completed 260 // Helper function called when same-document navigation completed
261 void OnSameDocumentNavigationCompleted(); 261 void OnSameDocumentNavigationCompleted(bool is_inpage_navigation);
262 262
263 const mojom::AutofillDriverPtr& GetAutofillDriver(); 263 const mojom::AutofillDriverPtr& GetAutofillDriver();
264 264
265 // The logins we have filled so far with their associated info. 265 // The logins we have filled so far with their associated info.
266 WebInputToPasswordInfoMap web_input_to_password_info_; 266 WebInputToPasswordInfoMap web_input_to_password_info_;
267 // A (sort-of) reverse map to |login_to_password_info_|. 267 // A (sort-of) reverse map to |login_to_password_info_|.
268 PasswordToLoginMap password_to_username_; 268 PasswordToLoginMap password_to_username_;
269 269
270 // Set if the user might be submitting a password form on the current page, 270 // Set if the user might be submitting a password form on the current page,
271 // but the submit may still fail (i.e. doesn't pass JavaScript validation). 271 // but the submit may still fail (i.e. doesn't pass JavaScript validation).
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 mojom::PasswordManagerDriverPtr password_manager_driver_; 307 mojom::PasswordManagerDriverPtr password_manager_driver_;
308 308
309 mojo::Binding<mojom::PasswordAutofillAgent> binding_; 309 mojo::Binding<mojom::PasswordAutofillAgent> binding_;
310 310
311 DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent); 311 DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);
312 }; 312 };
313 313
314 } // namespace autofill 314 } // namespace autofill
315 315
316 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 316 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698