components/autofill/content/common/autofill_types_struct_traits_unittest.cc - Issue 2859243004: Add metrics for PasswordForm submission types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_types_struct_traits_unittest.cc

Issue 2859243004: Add metrics for PasswordForm submission types (Closed)

Patch Set: addressed reviewer comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/common/autofill_types_struct_traits.cc ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_types_struct_traits_unittest.cc

diff --git a/components/autofill/content/common/autofill_types_struct_traits_unittest.cc b/components/autofill/content/common/autofill_types_struct_traits_unittest.cc

index dba2fa69c4ac8793d752e1d36a53cdc9bba13e32..ce4e7b42f655ad1fc202d552c3d401733f57abfa 100644

--- a/components/autofill/content/common/autofill_types_struct_traits_unittest.cc

+++ b/components/autofill/content/common/autofill_types_struct_traits_unittest.cc

@@ -100,6 +100,8 @@ void CreateTestPasswordForm(PasswordForm* form) {

form->is_public_suffix_match = true;

form->is_affiliation_based_match = true;

form->does_look_like_signup_form = true;

+ form->submission_event =

+ PasswordForm::SubmissionIndicatorEvent::SAME_DOCUMENT_NAVIGATION;

}

void CreateTestFormsPredictionsMap(FormsPredictionsMap* predictions) {