Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2859053006: Use constexpr TaskTraits constructor in base (part 2). (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab
CC:
chromium-reviews, gab+watch_chromium.org, danakj+watch_chromium.org, fdoray+watch_chromium.org, robliao+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in base (part 2). Part 1 https://codereview.chromium.org/2861833002/ didn't catch cases that didn't use the base:: prefix. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in base. BUG=713683 R=gab@chromium.org Review-Url: https://codereview.chromium.org/2859053006 Cr-Commit-Position: refs/heads/master@{#470195} Committed: https://chromium.googlesource.com/chromium/src/+/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5

Patch Set 1 #

Patch Set 2 : self-review #

Patch Set 3 : self-review #

Patch Set 4 : fix-build-error #

Patch Set 5 : fix-test-error #

Patch Set 6 : self-review #

Patch Set 7 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -215 lines) Patch
M base/observer_list_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/process/kill_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
M base/task_scheduler/post_task.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M base/task_scheduler/priority_queue_unittest.cc View 1 1 chunk +12 lines, -12 lines 0 comments Download
M base/task_scheduler/scheduler_single_thread_task_runner_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc View 1 2 7 chunks +18 lines, -27 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_impl_unittest.cc View 1 2 3 4 5 6 7 chunks +9 lines, -12 lines 0 comments Download
M base/task_scheduler/scheduler_worker_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M base/task_scheduler/sequence_unittest.cc View 1 chunk +20 lines, -25 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl_unittest.cc View 1 2 3 4 5 6 3 chunks +12 lines, -20 lines 0 comments Download
M base/task_scheduler/task_tracker_unittest.cc View 1 2 3 4 5 17 chunks +46 lines, -60 lines 0 comments Download
M base/task_scheduler/task_unittest.cc View 2 chunks +12 lines, -20 lines 0 comments Download
M base/test/scoped_task_scheduler_unittest.cc View 1 2 2 chunks +13 lines, -22 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (18 generated)
fdoray
PTAL
3 years, 7 months ago (2017-05-05 19:31:23 UTC) #1
gab
lgtm
3 years, 7 months ago (2017-05-05 19:35:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859053006/120001
3 years, 7 months ago (2017-05-08 19:13:14 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/405903)
3 years, 7 months ago (2017-05-08 19:24:18 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859053006/120001
3 years, 7 months ago (2017-05-08 20:05:27 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:18:49 UTC) #24
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/f7d6f760f8e0fd9fd4683b1d4162...

Powered by Google App Engine
This is Rietveld 408576698