Reland: Convert ChromeActivityTestCaseBase direct children to JUnit4

Reland: Convert ChromeActivityTestCaseBase direct children to JUnit4

This CL convert all the ChromeActivityTestCaseBase direct children tests to
JUnit4. All TouchCommon methods (dragTo, dragStart, etc) are refactored
to directly calling TouchCommon. For more on JUnit4 migration, check
src/testing/android/docs/junit4.md

Previous landing CL: https://codereview.chromium.org/2831823003

BUG=640116
Review-Url: https://codereview.chromium.org/2858933002
Cr-Commit-Position: refs/heads/master@{#469030}
Committed: https://chromium.googlesource.com/chromium/src/+/b5e2f44aa694f7db1db8b42831f1d2bb799f9b75

[the real yoland, 2017-05-03 16:37:18]

yolandyan@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org, tedchoc@chromium.org

[the real yoland, 2017-05-03 16:37:19]

the previous landing CL is in patch 1

[jbudorick, 2017-05-03 16:41:39]

On 2017/05/03 16:37:19, the real yoland wrote:
> the previous landing CL is in patch 1

the patch difference is oddly not useful here -- did you pull anything out other
than LauncherActivityTest?

[the real yoland, 2017-05-03 16:45:42]

On 2017/05/03 at 16:41:39, jbudorick wrote:
> On 2017/05/03 16:37:19, the real yoland wrote:
> > the previous landing CL is in patch 1
> 
> the patch difference is oddly not useful here -- did you pull anything out
other than LauncherActivityTest?

Ah, I see

LauncherActivityTest and ClearBrowsingDataPreferencesTest(just to be safe, I
will land ClearBrowsingDataPreferencesTest with a separate CL)

[the real yoland, 2017-05-03 16:45:48]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 16:46:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-05-03 17:02:44]

lgtm

[Ted C, 2017-05-03 17:06:43]

lgtm

[commit-bot: I haz the power, 2017-05-03 17:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 17:23:37]

Dry run: This issue passed the CQ dry run.

[the real yoland, 2017-05-03 17:51:56]

The CQ bit was checked by yolandyan@chromium.org

[commit-bot: I haz the power, 2017-05-03 17:52:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 18:00:12]

CQ is committing da patch.

Bot data: {"patchset_id": 10001, "attempt_start_ts": 1493833916883910,
"parent_rev": "902fe23a4f224a6b8b17769670943fd5f28e2f3b", "commit_rev":
"b5e2f44aa694f7db1db8b42831f1d2bb799f9b75"}

[commit-bot: I haz the power, 2017-05-03 18:00:25]

Description was changed from

==========
Reland: Convert ChromeActivityTestCaseBase direct children to JUnit4

This CL convert all the ChromeActivityTestCaseBase direct children tests to
JUnit4. All TouchCommon methods (dragTo, dragStart, etc) are refactored
to directly calling TouchCommon. For more on JUnit4 migration, check
src/testing/android/docs/junit4.md

Previous landing CL: https://codereview.chromium.org/2831823003

BUG=640116
==========

to

==========
Reland: Convert ChromeActivityTestCaseBase direct children to JUnit4

This CL convert all the ChromeActivityTestCaseBase direct children tests to
JUnit4. All TouchCommon methods (dragTo, dragStart, etc) are refactored
to directly calling TouchCommon. For more on JUnit4 migration, check
src/testing/android/docs/junit4.md

Previous landing CL: https://codereview.chromium.org/2831823003

BUG=640116

Review-Url: https://codereview.chromium.org/2858933002
Cr-Commit-Position: refs/heads/master@{#469030}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5e2f44aa694f7db1db8b42831f1...
==========

[commit-bot: I haz the power, 2017-05-03 18:00:31]

Committed patchset #2 (id:10001) as
https://chromium.googlesource.com/chromium/src/+/b5e2f44aa694f7db1db8b42831f1...

[the real yoland, 2017-05-03 21:02:39]

A revert of this CL (patchset #2 id:10001) has been created in
https://codereview.chromium.org/2860843002/ by yolandyan@chromium.org.

The reason for reverting is: :( ItemChooserDialogTest failing on
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tes...
and
https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit...
.