Convert ChromeActivityTestCaseBase direct children to JUnit4

Convert ChromeActivityTestCaseBase direct children to JUnit4

This CL convert all the ChromeActivityTestCaseBase direct children tests to
JUnit4. All TouchCommon methods (dragTo, dragStart, etc) are refactored
to directly calling TouchCommon. For more on JUnit4 migration, check
src/testing/android/docs/junit4.md

BUG=640116
Review-Url: https://codereview.chromium.org/2831823003
Cr-Commit-Position: refs/heads/master@{#468847}
Committed: https://chromium.googlesource.com/chromium/src/+/8e8d36a33e54fa305ac6842ccfafb03343d18d24

[the real yoland, 2017-04-25 19:06:30]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 19:07:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 19:59:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 19:59:37]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[the real yoland, 2017-04-26 00:04:28]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 00:04:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 01:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 01:03:31]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[the real yoland, 2017-04-26 04:24:10]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[the real yoland, 2017-04-26 04:24:25]

Patchset #5 (id:50001) has been deleted

[the real yoland, 2017-04-26 04:24:30]

Patchset #5 (id:50001) has been deleted

[commit-bot: I haz the power, 2017-04-26 04:24:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[the real yoland, 2017-04-26 04:24:36]

Patchset #4 (id:40001) has been deleted

[the real yoland, 2017-04-26 04:24:42]

Patchset #2 (id:10001) has been deleted

[the real yoland, 2017-04-26 04:24:49]

Patchset #2 (id:30001) has been deleted

[commit-bot: I haz the power, 2017-04-26 05:08:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 05:08:32]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[the real yoland, 2017-04-26 18:03:11]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[the real yoland, 2017-04-26 18:03:26]

yolandyan@chromium.org changed reviewers:
+ jbudorick@chromium.org, tedchoc@chromium.org

[commit-bot: I haz the power, 2017-04-26 18:03:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[the real yoland, 2017-04-26 18:11:45]

yolandyan@chromium.org changed reviewers:
+ mikecase@chromium.org

[commit-bot: I haz the power, 2017-04-26 18:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 18:45:24]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-04-27 18:05:27]

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java:31:
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
Create an array constant in ChromeActivityTestRule (or somewhere) for the
default Chrome test flags.  Having to duplicate these in every file is sad (and
if we need to add a new default flag that would be super painful).

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java:58:
public ChromeActivityTestRule<ChromeActivity> mActivityTestRule =
incorrectly inserted between the comment and the class

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java:238:
final AtomicReference<NavigationPopup> ref = new AtomicReference<>();
ref is unnecessarily terse IMO.

maybe popupReference or something along those lines (same comment elsewhere)

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java:242:
mActivityTestRule.startMainActivityWithURL("about:blank");
we should use startMainActivityOnBlankPage since we are moving this

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java:272:
Assert.assertTrue(mPanelManager.getRequestPanelShowCount() == 0);
if you were inclined, all these assertTrues here should be assertEquals, or
assertNull

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java:36:
@CommandLineFlags.Add({"enable-dom-distiller",
"reader-mode-heuristics=alwaystrue",
for cases like this if we have a default set of command line flags as I
mentioned previous, can we have two Add annotations on the same file?

Thinking it could be like:
@CommandLineFlags.Add({"enable-dom-distiller",
"reader-mode-heuristics=alwaystrue"})
@CommandLineFlags.Add(ChromeActivityTestRule.DEFAULT_FLAGS)

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:267:
Assert.assertTrue(!(google_summary.getSummary() instanceof SpannableString)
this should be assertEquals, but I guess we can fix this later if you prefer

[the real yoland, 2017-04-28 01:56:35]

Patchset #4 (id:80001) has been deleted

[the real yoland, 2017-04-28 02:03:29]

Thank you for the review, addressed the comments!

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java:31:
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
On 2017/04/27 at 18:05:27, Ted C wrote:
> Create an array constant in ChromeActivityTestRule (or somewhere) for the
default Chrome test flags.  Having to duplicate these in every file is sad (and
if we need to add a new default flag that would be super painful).

Commented below.

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java:58:
public ChromeActivityTestRule<ChromeActivity> mActivityTestRule =
On 2017/04/27 at 18:05:27, Ted C wrote:
> incorrectly inserted between the comment and the class

sorry, script problem.

Changed

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java:238:
final AtomicReference<NavigationPopup> ref = new AtomicReference<>();
On 2017/04/27 at 18:05:27, Ted C wrote:
> ref is unnecessarily terse IMO.
> 
> maybe popupReference or something along those lines (same comment elsewhere)

Done

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java:242:
mActivityTestRule.startMainActivityWithURL("about:blank");
On 2017/04/27 at 18:05:26, Ted C wrote:
> we should use startMainActivityOnBlankPage since we are moving this

Done

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java:272:
Assert.assertTrue(mPanelManager.getRequestPanelShowCount() == 0);
On 2017/04/27 at 18:05:27, Ted C wrote:
> if you were inclined, all these assertTrues here should be assertEquals, or
assertNull

Done

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java:36:
@CommandLineFlags.Add({"enable-dom-distiller",
"reader-mode-heuristics=alwaystrue",
On 2017/04/27 at 18:05:27, Ted C wrote:
> for cases like this if we have a default set of command line flags as I
mentioned previous, can we have two Add annotations on the same file?
> 
> Thinking it could be like:
> @CommandLineFlags.Add({"enable-dom-distiller",
"reader-mode-heuristics=alwaystrue"})
> @CommandLineFlags.Add(ChromeActivityTestRule.DEFAULT_FLAGS)

this would work with this CL to enable the annotation to be repeatable
(https://codereview.chromium.org/2846153003)
However, I don't think we have java8 enabled by default right now
(https://bugs.chromium.org/p/chromium/issues/detail?id=642600 which is blocked
on lint errors)
Also, a side-note, we are hoping to change annotation to rules during the
refactor, so these might go away.

If java8 isn't supported in time, we can also provide a static method that takes
in flag strings, and return an array of default and added flag strings.

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:267:
Assert.assertTrue(!(google_summary.getSummary() instanceof SpannableString)
On 2017/04/27 at 18:05:27, Ted C wrote:
> this should be assertEquals, but I guess we can fix this later if you prefer

Rebased this file, I think someone else changed before me.

[Ted C, 2017-04-28 22:57:46]

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java:31:
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
On 2017/04/28 02:03:28, the real yoland wrote:
> On 2017/04/27 at 18:05:27, Ted C wrote:
> > Create an array constant in ChromeActivityTestRule (or somewhere) for the
> default Chrome test flags.  Having to duplicate these in every file is sad
(and
> if we need to add a new default flag that would be super painful).
> 
> Commented below.

I don't see why the below comment prevents us from adding a constant now.  Even
if we want to move it to a rule later, I would rather us make it better in the
meantime and introducing a constant seems ok.

For the cases where classes need to add additional flags, then they can still
include them all but for the bulk of the classes that just need the defaults it
should just be a string.

https://codereview.chromium.org/2831823003/diff/90001/chrome/android/javatest...
File chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java
(right):

https://codereview.chromium.org/2831823003/diff/90001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java:35:
public ChromeActivityTestRule<ChromeActivity> mActivityTestRule =
any reason the rules are public?

[Ted C, 2017-04-29 06:13:01]

https://codereview.chromium.org/2831823003/diff/90001/chrome/android/javatest...
File chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java
(right):

https://codereview.chromium.org/2831823003/diff/90001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java:35:
public ChromeActivityTestRule<ChromeActivity> mActivityTestRule =
On 2017/04/28 22:57:46, Ted C wrote:
> any reason the rules are public?

nvm, just wrote a test using this setup and it crashes at runtime specifically
if this is not public

[the real yoland, 2017-05-01 23:05:02]

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java:31:
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
On 2017/04/28 at 22:57:46, Ted C wrote:
> On 2017/04/28 02:03:28, the real yoland wrote:
> > On 2017/04/27 at 18:05:27, Ted C wrote:
> > > Create an array constant in ChromeActivityTestRule (or somewhere) for the
> > default Chrome test flags.  Having to duplicate these in every file is sad
(and
> > if we need to add a new default flag that would be super painful).
> > 
> > Commented below.
> 
> I don't see why the below comment prevents us from adding a constant now. 
Even if we want to move it to a rule later, I would rather us make it better in
the meantime and introducing a constant seems ok.
> 
> For the cases where classes need to add additional flags, then they can still
include them all but for the bulk of the classes that just need the defaults it
should just be a string.

Hmm, my bad, I just realized one can't add array variable to an annotation.

e.g.
public static String[] DEFAULT_FLAGS = new String[] {"a", "b"};

@CommandLineFlags.Add(DEFAULT_FLAGS) //can not compile because a compile-time
constant is required as an annotation element, which means only enum, string,
primitive types :(

If we want to avoid repeating the same flags and also avoid using base classes,
maybe we can create an interface just for CommandLineFlags annotations.

e.g.
```
@CommandLineFlag.Add({a, b})
public inteface ChromeDefaultFlags {}

public class AudioTest implements ChromeDefaultFlags {...}
```

This does require some implementation change on
CommandLineFlags#getFlags(AnnotatedElement e)

but if commandline flags annotations are eventually to be replaced by test
rules, this might be a weird standard for a transitional stage for someone who
write tests

What do y'all think?

https://codereview.chromium.org/2831823003/diff/90001/chrome/android/javatest...
File chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java
(right):

https://codereview.chromium.org/2831823003/diff/90001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java:35:
public ChromeActivityTestRule<ChromeActivity> mActivityTestRule =
On 2017/04/28 at 22:57:46, Ted C wrote:
> any reason the rules are public?

ya, they are required by the JUnit4 runner since these value fetched
reflectively
If there is a java security manager, the runner can't set a private field to be
accessible, so the runner just enforce all fields to be public

[Ted C, 2017-05-02 00:09:56]

lgtm

I think we should see if there are other ways we could "extend" the annotation
for command line flags.  Maybe it could have an enum for default sets to include
or something, but that is also kind of gross.  But for now, we should do that
separately at this point.

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
File chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java
(right):

https://codereview.chromium.org/2831823003/diff/70001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java:31:
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
On 2017/05/01 23:05:02, the real yoland wrote:
> On 2017/04/28 at 22:57:46, Ted C wrote:
> > On 2017/04/28 02:03:28, the real yoland wrote:
> > > On 2017/04/27 at 18:05:27, Ted C wrote:
> > > > Create an array constant in ChromeActivityTestRule (or somewhere) for
the
> > > default Chrome test flags.  Having to duplicate these in every file is sad
> (and
> > > if we need to add a new default flag that would be super painful).
> > > 
> > > Commented below.
> > 
> > I don't see why the below comment prevents us from adding a constant now. 
> Even if we want to move it to a rule later, I would rather us make it better
in
> the meantime and introducing a constant seems ok.
> > 
> > For the cases where classes need to add additional flags, then they can
still
> include them all but for the bulk of the classes that just need the defaults
it
> should just be a string.
> 
> Hmm, my bad, I just realized one can't add array variable to an annotation.
> 
> e.g.
> public static String[] DEFAULT_FLAGS = new String[] {"a", "b"};
> 
> @CommandLineFlags.Add(DEFAULT_FLAGS) //can not compile because a compile-time
> constant is required as an annotation element, which means only enum, string,
> primitive types :(
> 
> If we want to avoid repeating the same flags and also avoid using base
classes,
> maybe we can create an interface just for CommandLineFlags annotations.
> 
> e.g.
> ```
> @CommandLineFlag.Add({a, b})
> public inteface ChromeDefaultFlags {}
> 
> public class AudioTest implements ChromeDefaultFlags {...}
> ```
> 
> This does require some implementation change on
> CommandLineFlags#getFlags(AnnotatedElement e)
> 
> but if commandline flags annotations are eventually to be replaced by test
> rules, this might be a weird standard for a transitional stage for someone who
> write tests
> 
> What do y'all think?

Sadness.  I don't know if I would go down that path.  We can likely just leave
it as it :-/

[the real yoland, 2017-05-02 01:08:26]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 01:09:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 01:13:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 01:13:51]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[the real yoland, 2017-05-02 02:42:46]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 02:43:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 04:39:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 04:39:12]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[the real yoland, 2017-05-02 23:01:56]

Patchset #5 (id:100001) has been deleted

[the real yoland, 2017-05-02 23:17:40]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 23:18:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[the real yoland, 2017-05-02 23:23:44]

Patchset #5 (id:100001) has been deleted

[the real yoland, 2017-05-03 00:04:47]

The CQ bit was unchecked by yolandyan@chromium.org

[the real yoland, 2017-05-03 00:15:10]

Patchset #5 (id:110001) has been deleted

[the real yoland, 2017-05-03 00:15:29]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[the real yoland, 2017-05-03 00:15:39]

Patchset #5 (id:110001) has been deleted

[commit-bot: I haz the power, 2017-05-03 00:16:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 00:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 00:55:47]

Dry run: This issue passed the CQ dry run.

[the real yoland, 2017-05-03 00:56:01]

The CQ bit was checked by yolandyan@chromium.org

[the real yoland, 2017-05-03 00:56:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2831823003/#ps120001
(title: "rebase and convert newly added test")

[commit-bot: I haz the power, 2017-05-03 00:56:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 01:05:38]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1493772961925010,
"parent_rev": "b68a2976a94249c55ad3b0bacee12bf047cacfc9", "commit_rev":
"8e8d36a33e54fa305ac6842ccfafb03343d18d24"}

[commit-bot: I haz the power, 2017-05-03 01:05:48]

Description was changed from

==========
Convert ChromeActivityTestCaseBase direct children to JUnit4

This CL convert all the ChromeActivityTestCaseBase direct children tests to
JUnit4. All TouchCommon methods (dragTo, dragStart, etc) are refactored
to directly calling TouchCommon. For more on JUnit4 migration, check
src/testing/android/docs/junit4.md

BUG=640116
==========

to

==========
Convert ChromeActivityTestCaseBase direct children to JUnit4

This CL convert all the ChromeActivityTestCaseBase direct children tests to
JUnit4. All TouchCommon methods (dragTo, dragStart, etc) are refactored
to directly calling TouchCommon. For more on JUnit4 migration, check
src/testing/android/docs/junit4.md

BUG=640116

Review-Url: https://codereview.chromium.org/2831823003
Cr-Commit-Position: refs/heads/master@{#468847}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e8d36a33e54fa305ac6842ccfaf...
==========

[commit-bot: I haz the power, 2017-05-03 01:05:50]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/8e8d36a33e54fa305ac6842ccfaf...

[jbudorick, 2017-05-03 03:32:48]

A revert of this CL (patchset #5 id:120001) has been created in
https://codereview.chromium.org/2853423003/ by jbudorick@chromium.org.

The reason for reverting is: Suspect this is causing issues on
LauncherActivityTest#testLaunchWithUrlNoScheme:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType....