Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: components/offline_pages/core/offline_page_model.h

Issue 2858803002: [Offline Pages] Adding support for removed-on-cache-reset pages to query. (Closed)
Patch Set: Fixing tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/offline_page_model.h
diff --git a/components/offline_pages/core/offline_page_model.h b/components/offline_pages/core/offline_page_model.h
index 434687e9e11ee63b6ed38501fd5e63a0d42a4b5f..41b4ff8f6d71460467ba9a6103e2ade9497ef581 100644
--- a/components/offline_pages/core/offline_page_model.h
+++ b/components/offline_pages/core/offline_page_model.h
@@ -131,6 +131,12 @@ class OfflinePageModel : public base::SupportsUserData {
virtual void DeletePagesByClientIds(const std::vector<ClientId>& client_ids,
const DeletePageCallback& callback) = 0;
+ // Deletes all pages matching |query|.
+ virtual void DeletePagesMatchingQuery(
dewittj 2017/05/03 21:55:09 I wonder if we shouldn't make it so easy :) and ma
romax 2017/05/03 23:23:08 Can't agree more! I've removed this method since t
+ std::unique_ptr<OfflinePageModelQuery> query,
+ const DeletePageCallback& callback) = 0;
+
+ // Retrieves all pages matching |query|.
virtual void GetPagesMatchingQuery(
std::unique_ptr<OfflinePageModelQuery> query,
const MultipleOfflinePageItemCallback& callback) = 0;

Powered by Google App Engine
This is Rietveld 408576698