[Offline Pages] Adding support for removed-on-cache-reset pages to query.

components/offline_pages/core/offline_page_model.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_CORE_OFFLINE_PAGE_MODEL_H_
 #define COMPONENTS_OFFLINE_PAGES_CORE_OFFLINE_PAGE_MODEL_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 113 matching lines @@
   virtual void MarkPageAccessed(int64_t offline_id) = 0;
 
   // Deletes pages based on |offline_ids|.
   virtual void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,
                                       const DeletePageCallback& callback) = 0;
 
   // Deletes all pages associated with any of |client_ids|.
   virtual void DeletePagesByClientIds(const std::vector<ClientId>& client_ids,
                                       const DeletePageCallback& callback) = 0;
 
+  // Deletes all pages matching |query|.
+  virtual void DeletePagesMatchingQuery(

[dewittj, 2017/05/03 21:55:09]

I wonder if we shouldn't make it so easy :) and make clients use a query
followed by DeletePagesByOfflineId. WDYT

[romax, 2017/05/03 23:23:08]

Can't agree more! I've removed this method since the only potentially current
client will be removed as well :)

+      std::unique_ptr<OfflinePageModelQuery> query,
+      const DeletePageCallback& callback) = 0;
+
+  // Retrieves all pages matching |query|.
   virtual void GetPagesMatchingQuery(
       std::unique_ptr<OfflinePageModelQuery> query,
       const MultipleOfflinePageItemCallback& callback) = 0;
 
   // Retrieves all pages associated with any of |client_ids|.
   virtual void GetPagesByClientIds(
       const std::vector<ClientId>& client_ids,
       const MultipleOfflinePageItemCallback& callback) = 0;
 
   // Deletes cached offline pages matching the URL predicate.
@@ skipping 33 matching lines @@
   // TODO(dougarnett): Remove this and its uses.
   virtual bool is_loaded() const = 0;
 
   // Returns the logger. Ownership is retained by the model.
   virtual OfflineEventLogger* GetLogger() = 0;
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_CORE_OFFLINE_PAGE_MODEL_H_