Chromium Code Reviews| Index: components/offline_pages/core/offline_page_model_impl_unittest.cc |
| diff --git a/components/offline_pages/core/offline_page_model_impl_unittest.cc b/components/offline_pages/core/offline_page_model_impl_unittest.cc |
| index 826638232cae804ab86532093384c83f1d170924..7b2ed57ed33783407752829e562f3de20338b426 100644 |
| --- a/components/offline_pages/core/offline_page_model_impl_unittest.cc |
| +++ b/components/offline_pages/core/offline_page_model_impl_unittest.cc |
| @@ -1295,6 +1295,28 @@ TEST_F(OfflinePageModelImplTest, GetPagesMatchingQuery) { |
| EXPECT_EQ(kTestUrl2, offline_pages[0].original_url); |
| } |
| +TEST_F(OfflinePageModelImplTest, DeletePagesMatchingQuery) { |
|
dewittj
2017/05/03 21:55:09
would be nice to use a query that has more complex
romax
2017/05/03 23:23:08
Since removed the newly added method, this test wi
|
| + SavePage(kTestUrl, kTestClientId1); |
| + SavePage(kTestUrl2, kTestClientId2); |
| + PumpLoop(); |
| + |
| + ASSERT_EQ(2UL, GetAllPages().size()); |
| + |
| + std::vector<ClientId> client_ids{kTestClientId1}; |
| + OfflinePageModelQueryBuilder builder; |
| + builder.SetClientIds(OfflinePageModelQuery::Requirement::INCLUDE_MATCHING, |
| + client_ids); |
| + |
| + model()->DeletePagesMatchingQuery( |
| + builder.Build(model()->GetPolicyController()), |
| + base::Bind(&OfflinePageModelImplTest::OnDeletePageDone, AsWeakPtr())); |
| + PumpLoop(); |
| + |
| + ASSERT_EQ(1UL, GetAllPages().size()); |
| + EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result()); |
| + EXPECT_EQ(kTestClientId1, last_deleted_client_id()); |
| +} |
| + |
| TEST(CommandLineFlagsTest, OfflineBookmarks) { |
| // Disabled by default. |
| EXPECT_FALSE(offline_pages::IsOfflineBookmarksEnabled()); |