[Offline Pages] Adding support for removed-on-cache-reset pages to query.

[Offline Pages] Adding support for removed-on-cache-reset pages to query.

Adding support for "removed on cache reset" pages to the query interface.
Also Adding a new interface on OfflinePageModel to delete pages matching
a specific query.

BUG=716142
Review-Url: https://codereview.chromium.org/2858803002
Cr-Commit-Position: refs/heads/master@{#469219}
Committed: https://chromium.googlesource.com/chromium/src/+/8d71fd71eeed601adca80aedf34c5aaabb41a321

[romax, 2017-05-02 22:59:35]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 23:00:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[romax, 2017-05-02 23:00:30]

romax@chromium.org changed reviewers:
+ dewittj@chromium.org

[romax, 2017-05-02 23:00:31]

Here's the first part of the separated patch for CL/2857493002.
PTAL, thanks!

[commit-bot: I haz the power, 2017-05-02 23:25:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 23:25:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[romax, 2017-05-02 23:43:49]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 23:44:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 00:37:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 00:37:17]

Dry run: This issue passed the CQ dry run.

[dewittj, 2017-05-03 21:55:09]

lgtm with nits

https://codereview.chromium.org/2858803002/diff/20001/components/offline_page...
File components/offline_pages/core/offline_page_model.h (right):

https://codereview.chromium.org/2858803002/diff/20001/components/offline_page...
components/offline_pages/core/offline_page_model.h:135: virtual void
DeletePagesMatchingQuery(
I wonder if we shouldn't make it so easy :) and make clients use a query
followed by DeletePagesByOfflineId. WDYT

https://codereview.chromium.org/2858803002/diff/20001/components/offline_page...
File components/offline_pages/core/offline_page_model_impl_unittest.cc (right):

https://codereview.chromium.org/2858803002/diff/20001/components/offline_page...
components/offline_pages/core/offline_page_model_impl_unittest.cc:1298:
TEST_F(OfflinePageModelImplTest, DeletePagesMatchingQuery) {
would be nice to use a query that has more complex matching, since delete by
client ID already exists.

[romax, 2017-05-03 23:23:08]

removed DeletePagesMatchingQuery since the client method which uses this has
been deleted as well.

https://codereview.chromium.org/2858803002/diff/20001/components/offline_page...
File components/offline_pages/core/offline_page_model.h (right):

https://codereview.chromium.org/2858803002/diff/20001/components/offline_page...
components/offline_pages/core/offline_page_model.h:135: virtual void
DeletePagesMatchingQuery(
On 2017/05/03 21:55:09, dewittj wrote:
> I wonder if we shouldn't make it so easy :) and make clients use a query
> followed by DeletePagesByOfflineId. WDYT

Can't agree more! I've removed this method since the only potentially current
client will be removed as well :)

https://codereview.chromium.org/2858803002/diff/20001/components/offline_page...
File components/offline_pages/core/offline_page_model_impl_unittest.cc (right):

https://codereview.chromium.org/2858803002/diff/20001/components/offline_page...
components/offline_pages/core/offline_page_model_impl_unittest.cc:1298:
TEST_F(OfflinePageModelImplTest, DeletePagesMatchingQuery) {
On 2017/05/03 21:55:09, dewittj wrote:
> would be nice to use a query that has more complex matching, since delete by
> client ID already exists.

Since removed the newly added method, this test will be removed.

[romax, 2017-05-03 23:24:40]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[dewittj, 2017-05-03 23:25:17]

https://codereview.chromium.org/2858803002/diff/40001/components/offline_page...
File components/offline_pages/core/offline_page_model.h (right):

https://codereview.chromium.org/2858803002/diff/40001/components/offline_page...
components/offline_pages/core/offline_page_model.h:134: // Retrieves all pages
matching |query|.
nit: don't bother changing this file :)

[commit-bot: I haz the power, 2017-05-03 23:25:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[romax, 2017-05-03 23:27:16]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 23:27:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 00:29:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 00:29:41]

Dry run: This issue passed the CQ dry run.

[romax, 2017-05-04 00:30:16]

The CQ bit was checked by romax@chromium.org

[romax, 2017-05-04 00:30:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2858803002/#ps60001
(title: "reset offline_page_model.h")

[commit-bot: I haz the power, 2017-05-04 00:31:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 00:36:31]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493857816451180,
"parent_rev": "d60018e0b72b5708797cebe57780ad559877164f", "commit_rev":
"8d71fd71eeed601adca80aedf34c5aaabb41a321"}

[commit-bot: I haz the power, 2017-05-04 00:36:41]

Description was changed from

==========
[Offline Pages] Adding support for removed-on-cache-reset pages to query.

Adding support for "removed on cache reset" pages to the query interface.
Also Adding a new interface on OfflinePageModel to delete pages matching
a specific query.

BUG=716142
==========

to

==========
[Offline Pages] Adding support for removed-on-cache-reset pages to query.

Adding support for "removed on cache reset" pages to the query interface.
Also Adding a new interface on OfflinePageModel to delete pages matching
a specific query.

BUG=716142

Review-Url: https://codereview.chromium.org/2858803002
Cr-Commit-Position: refs/heads/master@{#469219}
Committed:
https://chromium.googlesource.com/chromium/src/+/8d71fd71eeed601adca80aedf34c...
==========

[commit-bot: I haz the power, 2017-05-04 00:36:45]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8d71fd71eeed601adca80aedf34c...