Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2858803002: [Offline Pages] Adding support for removed-on-cache-reset pages to query. (Closed)

Created:
3 years, 7 months ago by romax
Modified:
3 years, 7 months ago
Reviewers:
dewittj
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Adding support for removed-on-cache-reset pages to query. Adding support for "removed on cache reset" pages to the query interface. Also Adding a new interface on OfflinePageModel to delete pages matching a specific query. BUG=716142 Review-Url: https://codereview.chromium.org/2858803002 Cr-Commit-Position: refs/heads/master@{#469219} Committed: https://chromium.googlesource.com/chromium/src/+/8d71fd71eeed601adca80aedf34c5aaabb41a321

Patch Set 1 #

Patch Set 2 : Fixing tests. #

Total comments: 4

Patch Set 3 : comments from dewittj@. #

Total comments: 1

Patch Set 4 : reset offline_page_model.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -8 lines) Patch
M components/offline_pages/core/client_policy_controller_unittest.cc View 1 12 chunks +22 lines, -6 lines 0 comments Download
M components/offline_pages/core/offline_page_model_query.h View 2 chunks +8 lines, -0 lines 0 comments Download
M components/offline_pages/core/offline_page_model_query.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M components/offline_pages/core/offline_page_model_query_unittest.cc View 2 chunks +41 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (19 generated)
romax
Here's the first part of the separated patch for CL/2857493002. PTAL, thanks!
3 years, 7 months ago (2017-05-02 23:00:31 UTC) #4
dewittj
lgtm with nits https://codereview.chromium.org/2858803002/diff/20001/components/offline_pages/core/offline_page_model.h File components/offline_pages/core/offline_page_model.h (right): https://codereview.chromium.org/2858803002/diff/20001/components/offline_pages/core/offline_page_model.h#newcode135 components/offline_pages/core/offline_page_model.h:135: virtual void DeletePagesMatchingQuery( I wonder if ...
3 years, 7 months ago (2017-05-03 21:55:09 UTC) #11
romax
removed DeletePagesMatchingQuery since the client method which uses this has been deleted as well. https://codereview.chromium.org/2858803002/diff/20001/components/offline_pages/core/offline_page_model.h ...
3 years, 7 months ago (2017-05-03 23:23:08 UTC) #12
dewittj
https://codereview.chromium.org/2858803002/diff/40001/components/offline_pages/core/offline_page_model.h File components/offline_pages/core/offline_page_model.h (right): https://codereview.chromium.org/2858803002/diff/40001/components/offline_pages/core/offline_page_model.h#newcode134 components/offline_pages/core/offline_page_model.h:134: // Retrieves all pages matching |query|. nit: don't bother ...
3 years, 7 months ago (2017-05-03 23:25:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858803002/60001
3 years, 7 months ago (2017-05-04 00:31:08 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 00:36:45 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8d71fd71eeed601adca80aedf34c...

Powered by Google App Engine
This is Rietveld 408576698