arc: Support UNINSTALL_SHORTCUT

components/arc/common/app.mojom

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Next MinVersion: 18
+// Next MinVersion: 19
 
 module arc.mojom;
 
 import "scale_factor.mojom";
 import "screen_rect.mojom";
 
 // Describes OrientationLock request.
 // Note: ChromeOS currently assumes the internal panel is always landscape.
 // All rotation angles mentioned here are measured clockwise.
 [Extensible]
@@ skipping 52 matching lines @@
 // Page for ShowPackageInfoOnPage.
 [Extensible]
 enum ShowPackageInfoPage {
   // The main package info page.
   MAIN = 0,
 
   // Page for managing links assigned to the app.
   MANAGE_LINKS = 1,
 };
 
-// Next method ID: 16
+// Next method ID: 17
 interface AppHost {
   // Sends newly added ARC app to Chrome. This message is sent when ARC receives
   // package added notification. Multiple apps may be added in the one package.
   [MinVersion=1] OnAppAddedDeprecated@2(AppInfo app);
 
   // Receives an icon of required |scale_factor| for specific ARC app. The app
   // is defined by |package_name| and |activity|. The icon content cannot be
   // empty and must match to |scale_factor| assuming 48x48 for
   // SCALE_FACTOR_100P.  |scale_factor| is an enum defined at ui/base/layout.h.
   // |icon_png_data| is a png-encoded image.
@@ skipping 52 matching lines @@
       [MinVersion=17] string? package_name@0);
 
   // Notifies that Play Store installation is finished. |result| contains
   // details of installation result.
   [MinVersion=16] OnInstallationFinished@15(
       [MinVersion=17] InstallationResult? result@1);
 
   // Notifies that task requested orientation lock.
   [MinVersion=12] OnTaskOrientationLockRequested@12(int32 task_id,
                                                     OrientationLock lock);
+
+  // Notifies that an application shortcut needs to be deleted. Shortcut is
+  // defined by it's |intent_uri| and |package_name|.

[Luis Héctor Chávez, 2017/05/02 19:48:17]

nit: s/it's/its/.

Also, is it possible to use the ShortcutInfo struct here too, for consistency?

[khmel, 2017/05/02 20:09:43]

Renamed. I tried to use ShortcutInfo in my first impl. However it failed to
serialize ShortcutInfo because this structure contains non-null label  and
icon_resource_id. Of cause it possible for uninstall to pass "" for label and
icon_resource_id but this looks like a hack. Also it is possible to mark them as
nullable in mojo but after this we have to add additional check for
onInstallShortcut. 
Counting that and fact that half of fields is not required I decided to pass
package and intent directly.

[Luis Héctor Chávez, 2017/05/02 20:23:49]

Ah that is very unfortunate :/ All right, seems reasonable.

+  [MinVersion=18] OnUninstallShortcut@16(string package_name,
+                                         string intent_uri);
 };
 
 // TODO(lhchavez): Migrate all request/response messages to Mojo.
 // Next method ID: 16
 // Deprecated method ID: 9
 interface AppInstance {
   Init@0(AppHost host_ptr);
 
   // Query if a given resolution can be handled by the application. Returns true
   // if it can.
@@ skipping 56 matching lines @@
                                            ShowPackageInfoPage page,
                                            ScreenRect dimension_on_screen);
 
   // Sets notification setting for the package.
   [MinVersion=6] SetNotificationsEnabled@10(string package_name, bool enabled);
 
   // Sends a request to ARC to uninstall the given package.  Error (if ever
   // happens) is ignored, and uninstall option should appear in the UI.
   [MinVersion=2] UninstallPackage@5(string package_name);
 };