Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2858683005: Add a virtual destructor to WebCredentialManagerClient. (Closed)

Created:
3 years, 7 months ago by vasilii
Modified:
3 years, 7 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a virtual destructor to WebCredentialManagerClient. A class with virtual methods should have a virtual destructor. BUG=697810 Review-Url: https://codereview.chromium.org/2858683005 Cr-Commit-Position: refs/heads/master@{#469001} Committed: https://chromium.googlesource.com/chromium/src/+/b22c6827f2af4c6b6a2da7204e62992c278d2abf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/shell/test_runner/mock_credential_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebCredentialManagerClient.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
vasilii
Hi Mike, please review. I'm not claiming that the CL fixes the root cause of ...
3 years, 7 months ago (2017-05-03 15:01:29 UTC) #4
Mike West
lgtm
3 years, 7 months ago (2017-05-03 15:24:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683005/1
3 years, 7 months ago (2017-05-03 15:40:08 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 16:35:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b22c6827f2af4c6b6a2da7204e62...

Powered by Google App Engine
This is Rietveld 408576698