Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: content/shell/test_runner/mock_credential_manager_client.h

Issue 2858683005: Add a virtual destructor to WebCredentialManagerClient. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/public/platform/WebCredentialManagerClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_TEST_RUNNER_MOCK_CREDENTIAL_MANAGER_CLIENT_H_ 5 #ifndef CONTENT_SHELL_TEST_RUNNER_MOCK_CREDENTIAL_MANAGER_CLIENT_H_
6 #define CONTENT_SHELL_TEST_RUNNER_MOCK_CREDENTIAL_MANAGER_CLIENT_H_ 6 #define CONTENT_SHELL_TEST_RUNNER_MOCK_CREDENTIAL_MANAGER_CLIENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "third_party/WebKit/public/platform/WebCredentialManagerClient.h" 11 #include "third_party/WebKit/public/platform/WebCredentialManagerClient.h"
12 #include "third_party/WebKit/public/platform/WebCredentialManagerError.h" 12 #include "third_party/WebKit/public/platform/WebCredentialManagerError.h"
13 #include "third_party/WebKit/public/platform/WebVector.h" 13 #include "third_party/WebKit/public/platform/WebVector.h"
14 14
15 namespace blink { 15 namespace blink {
16 class WebCredential; 16 class WebCredential;
17 class WebURL; 17 class WebURL;
18 } 18 }
19 19
20 namespace test_runner { 20 namespace test_runner {
21 21
22 class MockCredentialManagerClient : public blink::WebCredentialManagerClient { 22 class MockCredentialManagerClient : public blink::WebCredentialManagerClient {
23 public: 23 public:
24 MockCredentialManagerClient(); 24 MockCredentialManagerClient();
25 virtual ~MockCredentialManagerClient(); 25 ~MockCredentialManagerClient() override;
26 26
27 // We take ownership of the |credential|. 27 // We take ownership of the |credential|.
28 void SetResponse(blink::WebCredential* credential); 28 void SetResponse(blink::WebCredential* credential);
29 void SetError(const std::string& error); 29 void SetError(const std::string& error);
30 30
31 // blink::WebCredentialManager: 31 // blink::WebCredentialManager:
32 void DispatchStore(const blink::WebCredential& credential, 32 void DispatchStore(const blink::WebCredential& credential,
33 NotificationCallbacks* callbacks) override; 33 NotificationCallbacks* callbacks) override;
34 void DispatchRequireUserMediation(NotificationCallbacks* callbacks) override; 34 void DispatchRequireUserMediation(NotificationCallbacks* callbacks) override;
35 void DispatchGet(bool zero_click_only, 35 void DispatchGet(bool zero_click_only,
36 bool include_passwords, 36 bool include_passwords,
37 const blink::WebVector<blink::WebURL>& federations, 37 const blink::WebVector<blink::WebURL>& federations,
38 RequestCallbacks* callbacks) override; 38 RequestCallbacks* callbacks) override;
39 39
40 private: 40 private:
41 std::unique_ptr<blink::WebCredential> credential_; 41 std::unique_ptr<blink::WebCredential> credential_;
42 blink::WebCredentialManagerError error_; 42 blink::WebCredentialManagerError error_;
43 43
44 DISALLOW_COPY_AND_ASSIGN(MockCredentialManagerClient); 44 DISALLOW_COPY_AND_ASSIGN(MockCredentialManagerClient);
45 }; 45 };
46 46
47 } // namespace test_runner 47 } // namespace test_runner
48 48
49 #endif // CONTENT_SHELL_TEST_RUNNER_MOCK_CREDENTIAL_MANAGER_CLIENT_H_ 49 #endif // CONTENT_SHELL_TEST_RUNNER_MOCK_CREDENTIAL_MANAGER_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/public/platform/WebCredentialManagerClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698