Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2858683002: Roll HarfBuzz to 1.4.6 (Closed)

Created:
3 years, 7 months ago by eae
Modified:
3 years, 7 months ago
Reviewers:
drott
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -110 lines) Patch
M third_party/harfbuzz-ng/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/NEWS View 1 chunk +37 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer-serialize.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-common.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-face.cc View 5 chunks +18 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-face-private.hh View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-fallback-shape.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.cc View 8 chunks +61 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-font-private.hh View 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-graphite2.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-graphite2.cc View 10 chunks +30 lines, -43 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.cc View 3 chunks +22 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh View 3 chunks +27 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-private.hh View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map-private.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-math.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.cc View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-table.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar-machine.hh View 10 chunks +19 lines, -19 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-var.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-var-hvar-table.hh View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-var-mvar-table.hh View 1 chunk +110 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape-plan.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shaper-private.hh View 1 chunk +10 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-version.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683002/1
3 years, 7 months ago (2017-05-02 19:00:15 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/409139) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-05-02 19:12:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683002/20001
3 years, 7 months ago (2017-05-02 20:37:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/443587)
3 years, 7 months ago (2017-05-02 21:52:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683002/20001
3 years, 7 months ago (2017-05-02 21:52:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d90b34b2c01631495508bd595a17dbe60fe061c6
3 years, 7 months ago (2017-05-02 22:57:19 UTC) #13
drott
3 years, 7 months ago (2017-05-18 16:51:29 UTC) #14
Message was sent while issue was closed. 
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698