third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc - Issue 2858683002: Roll HarfBuzz to 1.4.6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc

Issue 2858683002: Roll HarfBuzz to 1.4.6 (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc

diff --git a/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc b/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc

index 56ec5cd65cfb38b0d86e8c33300d0b8119a1680a..57ffc1dc5fee5e12c5c9b6fcef3da49253b78e96 100644

--- a/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc

+++ b/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc

@@ -540,7 +540,7 @@ apply_stch (const hb_ot_shape_plan_t *plan,

/* See if we can improve the fit by adding an extra repeat and squeezing them together a bit. */

hb_position_t extra_repeat_overlap = 0;

hb_position_t shortfall = sign * w_remaining - sign * w_repeating * (n_copies + 1);

- if (shortfall > 0)

+ if (shortfall > 0 && n_repeating > 0)

{

++n_copies;

hb_position_t excess = (n_copies + 1) * sign * w_repeating - sign * w_remaining;