Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 2858643002: PS - Filtering activeTab URL (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tab_util.cc
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
index ffaad663823c3a21a005a7035048a64def64531b..3c51503a42529d026967ca9cb7970422487a7ed4 100644
--- a/chrome/browser/extensions/extension_tab_util.cc
+++ b/chrome/browser/extensions/extension_tab_util.cc
@@ -126,6 +126,13 @@ ExtensionTabUtil::OpenTabParams::OpenTabParams()
ExtensionTabUtil::OpenTabParams::~OpenTabParams() {
}
+// static
+void ExtensionTabUtil::PlatformSpecificFiltering(
+ const std::string& extension_id, api::tabs::Tab* tab) {
+ if (g_delegate)
+ g_delegate->ScrubTabForExtension(extension_id, tab);
Ivan Šandrk 2017/05/03 13:00:51 PlatformSpecificFiltering vs. ScrubTabForExtension
Devlin 2017/05/03 15:14:15 I don't feel strongly on the naming, but see also
+}
+
// Opens a new tab for a given extension. Returns NULL and sets |error| if an
// error occurs.
base::DictionaryValue* ExtensionTabUtil::OpenTab(
@@ -488,8 +495,7 @@ void ExtensionTabUtil::ScrubTabForExtension(const Extension* extension,
tab->title.reset();
tab->fav_icon_url.reset();
}
- if (g_delegate)
- g_delegate->ScrubTabForExtension(extension, contents, tab);
+ PlatformSpecificFiltering(extension ? extension->id() : "", tab);
}
bool ExtensionTabUtil::GetTabStripModel(const WebContents* web_contents,

Powered by Google App Engine
This is Rietveld 408576698