PS - Filtering activeTab URL

chrome/browser/extensions/extension_tab_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tab_util.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 108 matching lines @@
 
 }  // namespace
 
 ExtensionTabUtil::OpenTabParams::OpenTabParams()
     : create_browser_if_needed(false) {
 }
 
 ExtensionTabUtil::OpenTabParams::~OpenTabParams() {
 }
 
+// static
+void ExtensionTabUtil::PlatformSpecificFiltering(
+    const std::string& extension_id, api::tabs::Tab* tab) {
+  if (g_delegate)
+    g_delegate->ScrubTabForExtension(extension_id, tab);

[Ivan Šandrk, 2017/05/03 13:00:51]

PlatformSpecificFiltering vs. ScrubTabForExtension

Seems as now I have a naming inconsistency maybe? Anyway I think I prefer the
name PlatformSpecificFiltering. WDYT?

[Devlin, 2017/05/03 15:14:15]

I don't feel strongly on the naming, but see also comment in
extension_action_api.cc that would make this method unnecessary.

+}
+
 // Opens a new tab for a given extension. Returns NULL and sets |error| if an
 // error occurs.
 base::DictionaryValue* ExtensionTabUtil::OpenTab(
     UIThreadExtensionFunction* function,
     const OpenTabParams& params,
     bool user_gesture,
     std::string* error) {
   ChromeExtensionFunctionDetails chrome_details(function);
   Profile* profile = chrome_details.GetProfile();
   // windowId defaults to "current" window.
@@ skipping 342 matching lines @@
     bool host_permission = extension->permissions_data()
                                ->active_permissions()
                                .HasExplicitAccessToOrigin(GURL(url));
     has_permission = api_permission || host_permission;
   }
   if (!has_permission) {
     tab->url.reset();
     tab->title.reset();
     tab->fav_icon_url.reset();
   }
-  if (g_delegate)
-    g_delegate->ScrubTabForExtension(extension, contents, tab);
+  PlatformSpecificFiltering(extension ? extension->id() : "", tab);
 }
 
 bool ExtensionTabUtil::GetTabStripModel(const WebContents* web_contents,
                                         TabStripModel** tab_strip_model,
                                         int* tab_index) {
   DCHECK(web_contents);
   DCHECK(tab_strip_model);
   DCHECK(tab_index);
 
   for (auto* browser : *BrowserList::GetInstance()) {
@@ skipping 212 matching lines @@
   chrome::ShowSingletonTabOverwritingNTP(browser, params);
   return true;
 }
 
 // static
 bool ExtensionTabUtil::BrowserSupportsTabs(Browser* browser) {
   return browser && browser->tab_strip_model() && !browser->is_devtools();
 }
 
 }  // namespace extensions