PS - Filtering activeTab URL

chrome/browser/extensions/api/extension_action/extension_action_api.cc

Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc
diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
index 037f8b309b607f4fe7be86f3a094ea970e2ca0ed..210e187d37c8b6a182e8100f2c1e1ebaf414d6c7 100644
--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc
+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
@@ -225,7 +225,11 @@ void ExtensionActionAPI::DispatchExtensionActionClicked(
 
   if (event_name) {
     std::unique_ptr<base::ListValue> args(new base::ListValue());
-    args->Append(ExtensionTabUtil::CreateTabObject(web_contents)->ToValue());
+    std::unique_ptr<api::tabs::Tab> tab =
+        ExtensionTabUtil::CreateTabObject(web_contents);
+    ExtensionTabUtil::PlatformSpecificFiltering(extension_action.extension_id(),

[Ivan Šandrk, 2017/05/03 13:00:50]

Should I test this part maybe?

[Devlin, 2017/05/03 15:14:15]

Actually, I think that what we should be doing is passing in the extension as
part of the CreateTabObject call so that we perform the scrubbing there.  I
think it's probably a bug that we don't do that already.

Note that doing this *could* potentially break extensions if they happen to be
relying on getting the url of the tab while also not having host permission,
tabs permission, or activeTab permission, but I think that's the right behavior.
 We shouldn't be surfacing this information to the extension otherwise.

[Ivan Šandrk, 2017/05/03 17:52:46]

Right, thanks for the suggestion. Done.

+                                                tab.get());
+    args->Append(tab->ToValue());
 
     DispatchEventToExtension(web_contents->GetBrowserContext(),
                              extension_action.extension_id(), histogram_value,