Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2858593002: [Courgette] Clean up EnsembleProgram. (Closed)

Created:
3 years, 7 months ago by huangs
Modified:
3 years, 7 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, huangs+watch_chromium.org, chrisha
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Courgette] Clean up EnsembleProgram. Before commiting the main CL for AssemblyProgram reduction, we clean up EnsenbleProgram to reduce noise. Details: - Fix includes and comments; run linter and formatter. - EncodedProgram::EvaluateRel32ARM(): Change non-const ref params to pointers. BUG=660980 Review-Url: https://codereview.chromium.org/2858593002 Cr-Commit-Position: refs/heads/master@{#468685} Committed: https://chromium.googlesource.com/chromium/src/+/19281f34d8f96eebe583cd7ccea1da56b9621854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M courgette/encoded_program.h View 4 chunks +29 lines, -27 lines 0 comments Download
M courgette/encoded_program.cc View 4 chunks +24 lines, -25 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
huangs
Quick cleanup to reduce noise before big AssemblyProgram reduction CL. PTAL. Thanks!
3 years, 7 months ago (2017-05-02 15:46:09 UTC) #3
Will Harris
lgtm thanks for splitting these CLs up.
3 years, 7 months ago (2017-05-02 16:22:01 UTC) #6
huangs
Thanks for the review. Committing!
3 years, 7 months ago (2017-05-02 16:54:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858593002/1
3 years, 7 months ago (2017-05-02 16:54:52 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:59:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/19281f34d8f96eebe583cd7ccea1...

Powered by Google App Engine
This is Rietveld 408576698