Use FreeType for OpenType Variations on CoreText < 10.12

Use FreeType for OpenType Variations on CoreText < 10.12

CoreText in versions older than Sierra has limited support for OpenType
variations, for example it fails to pass GPOS tests with variation
parameters applied. Use FreeType in those cases, similar to our approach
on Windows.

BUG=714553
TEST=/fast/text/variable-fonts/*
R=behdad, bungeman, eae

Review-Url: https://codereview.chromium.org/2858573002
Cr-Commit-Position: refs/heads/master@{#469980}
Committed: https://chromium.googlesource.com/chromium/src/+/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e

[drott, 2017-05-02 13:55:17]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 13:55:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 14:35:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 14:35:38]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[drott, 2017-05-03 06:46:21]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 06:46:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 06:50:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 06:50:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[drott, 2017-05-03 07:17:30]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 07:17:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 09:08:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 09:08:40]

Dry run: This issue passed the CQ dry run.

[drott, 2017-05-05 11:13:14]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 11:13:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 15:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 15:04:49]

Dry run: This issue passed the CQ dry run.

[drott, 2017-05-05 15:55:07]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 15:55:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2017-05-05 16:22:19]

Description was changed from

==========
Use FreeType for OpenType Variations on CoreText < 10.12

CoreText in versions older than Sierra has limited support for OpenType
variations, for example it fails to pass GPOS tests with variation
parameters applied. Use FreeType in those cases, similar to our approach
on Windows.

BUG=714553
TEST=/fast/text/variable-fonts/variable-gpos-m2b.html
R=behdad, bungeman, eae
==========

to

==========
Use FreeType for OpenType Variations on CoreText < 10.12

CoreText in versions older than Sierra has limited support for OpenType
variations, for example it fails to pass GPOS tests with variation
parameters applied. Use FreeType in those cases, similar to our approach
on Windows.

BUG=714553
TEST=/fast/text/variable-fonts/*
R=behdad, bungeman, eae
==========

[eae, 2017-05-05 16:34:28]

LGTM

[commit-bot: I haz the power, 2017-05-05 17:57:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 17:57:16]

Dry run: This issue passed the CQ dry run.

[bungeman-chromium, 2017-05-05 21:02:51]

bungeman@chromium.org changed reviewers:
+ bungeman@chromium.org

[bungeman-chromium, 2017-05-05 21:02:52]

https://codereview.chromium.org/2858573002/diff/80001/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/2858573002/diff/80001/skia/BUILD.gn#newcode47
skia/BUILD.gn:47: if (is_win || is_mac) {
I know it doesn't actually exist yet, but is this a good place to use
use_system_freetype instead?

[drott, 2017-05-08 07:45:47]

https://codereview.chromium.org/2858573002/diff/80001/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/2858573002/diff/80001/skia/BUILD.gn#newcode47
skia/BUILD.gn:47: if (is_win || is_mac) {
Yes, sounds good, I'll do that once the other CL lands, filed crbug.com/719345
to track.

[drott, 2017-05-08 07:45:51]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2017-05-08 07:46:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 07:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 07:51:10]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[drott, 2017-05-08 08:29:30]

The CQ bit was checked by drott@chromium.org

[drott, 2017-05-08 08:29:30]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2858573002/#ps100001
(title: "Use FreeType for OpenType Variations on CoreText < 10.12")

[commit-bot: I haz the power, 2017-05-08 08:30:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 08:39:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 08:39:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[drott, 2017-05-08 14:09:56]

Ben, could you review the skia/BUILD.gn change? Thank you in advance. I can't
commit without an owner's approval in that directory. (Would you be okay if I
became an OWNER for this directory?)

[bungeman-skia, 2017-05-08 14:13:31]

bungeman@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2017-05-08 14:13:31]

lgtm

[drott, 2017-05-08 14:13:56]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2017-05-08 14:14:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2017-05-08 14:14:35]

On 2017/05/08 14:09:56, drott wrote:
> Ben, could you review the skia/BUILD.gn change? Thank you in advance. I can't
> commit without an owner's approval in that directory. (Would you be okay if I
> became an OWNER for this directory?)

You should ask reed or hcm, as they're kinda the 'super owners'.

[commit-bot: I haz the power, 2017-05-08 14:18:49]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494252836043530,
"parent_rev": "da2a48d9f7403a1fbee3a5984d442a49ef14a01c", "commit_rev":
"4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e"}

[commit-bot: I haz the power, 2017-05-08 14:19:01]

Description was changed from

==========
Use FreeType for OpenType Variations on CoreText < 10.12

CoreText in versions older than Sierra has limited support for OpenType
variations, for example it fails to pass GPOS tests with variation
parameters applied. Use FreeType in those cases, similar to our approach
on Windows.

BUG=714553
TEST=/fast/text/variable-fonts/*
R=behdad, bungeman, eae
==========

to

==========
Use FreeType for OpenType Variations on CoreText < 10.12

CoreText in versions older than Sierra has limited support for OpenType
variations, for example it fails to pass GPOS tests with variation
parameters applied. Use FreeType in those cases, similar to our approach
on Windows.

BUG=714553
TEST=/fast/text/variable-fonts/*
R=behdad, bungeman, eae

Review-Url: https://codereview.chromium.org/2858573002
Cr-Commit-Position: refs/heads/master@{#469980}
Committed:
https://chromium.googlesource.com/chromium/src/+/4eaf7dfd6d9ce67d8b85b028af09...
==========

[commit-bot: I haz the power, 2017-05-08 14:19:03]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/4eaf7dfd6d9ce67d8b85b028af09...