third_party/WebKit/Source/platform/fonts/FontPlatformData.h - Issue 2858573002: Use FreeType for OpenType Variations on CoreText < 10.12

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontPlatformData.h

Issue 2858573002: Use FreeType for OpenType Variations on CoreText < 10.12 (Closed)

Patch Set: Use FreeType for OpenType Variations on CoreText < 10.12 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/FontPlatformData.h

diff --git a/third_party/WebKit/Source/platform/fonts/FontPlatformData.h b/third_party/WebKit/Source/platform/fonts/FontPlatformData.h

index 86b210872d71eb44808a3241923851eb525608d7..d159487ca4f87917bd9c5c2dbc6dd162e5968503 100644

--- a/third_party/WebKit/Source/platform/fonts/FontPlatformData.h

+++ b/third_party/WebKit/Source/platform/fonts/FontPlatformData.h

@@ -110,6 +110,10 @@ class PLATFORM_EXPORT FontPlatformData {

~FontPlatformData();

#if OS(MACOSX)

+ // These methods return a nullptr for FreeType backed SkTypefaces, compare

+ // FontCustomPlatformData, which are used for variable fonts on Mac OS <

+ // 10.12. They should not return nullptr otherwise. So they allow

+ // distinguishing which backend the SkTypeface is using.

CTFontRef CtFont() const;

CGFontRef CgFont() const;

#endif