Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2858443002: Removed unusual ASSERT_FALSE(HasFailure()) calls from MHTMLTest.cpp (Closed)

Created:
3 years, 7 months ago by carlosk
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unusual ASSERT_FALSE(HasFailure()) calls from MHTMLTest.cpp This change reverts the previous additions of this unusual check calls. BUG=672313 Review-Url: https://codereview.chromium.org/2858443002 Cr-Commit-Position: refs/heads/master@{#468552} Committed: https://chromium.googlesource.com/chromium/src/+/183d5a9be5ecd0321996d17e84e6352a96113ee5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/web/tests/MHTMLTest.cpp View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
carlosk
dcheng@ PTAL.
3 years, 7 months ago (2017-05-02 01:13:47 UTC) #2
dcheng
lgtm
3 years, 7 months ago (2017-05-02 02:19:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858443002/1
3 years, 7 months ago (2017-05-02 02:59:43 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 04:05:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/183d5a9be5ecd0321996d17e84e6...

Powered by Google App Engine
This is Rietveld 408576698