Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: third_party/WebKit/Source/web/tests/MHTMLTest.cpp

Issue 2858443002: Removed unusual ASSERT_FALSE(HasFailure()) calls from MHTMLTest.cpp (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/MHTMLTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/MHTMLTest.cpp b/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
index 33f9e9ed13fa447ff5d97330b89a57b183e82ebf..b1fc8225285047be40ed22037c1067584c4ef4ec 100644
--- a/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
+++ b/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
@@ -166,10 +166,8 @@ class MHTMLTest : public ::testing::Test {
// Validate the generated MHTML.
MHTMLParser parser(
SharedBuffer::Create(mhtml_data->data(), mhtml_data->length()));
- if (parser.ParseArchive().IsEmpty()) {
- ADD_FAILURE() << "Invalid MHTML";
- return RawData::Create();
- }
+ EXPECT_FALSE(parser.ParseArchive().IsEmpty())
+ << "Generated MHTML is malformed";
return mhtml_data.Release();
}
@@ -216,7 +214,6 @@ TEST_F(MHTMLTest, TestMHTMLEncoding) {
AddTestResources();
RefPtr<RawData> data = Serialize("Test Serialization", "text/html",
MHTMLArchive::kUseDefaultEncoding);
- ASSERT_FALSE(HasFailure());
// Read the MHTML data line per line and do some pseudo-parsing to make sure
// the right encoding is used for the different sections.
@@ -253,7 +250,6 @@ TEST_F(MHTMLTest, MHTMLFromScheme) {
AddTestResources();
RefPtr<RawData> raw_data = Serialize("Test Serialization", "text/html",
MHTMLArchive::kUseDefaultEncoding);
- ASSERT_FALSE(HasFailure());
RefPtr<SharedBuffer> data =
SharedBuffer::Create(raw_data->data(), raw_data->length());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698