Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2858393004: Revert of Reenable WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate. (Closed)

Created:
3 years, 7 months ago by johnme
Modified:
3 years, 7 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenable WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate. (patchset #1 id:1 of https://codereview.chromium.org/2863633003/ ) Reason for revert: This test immediately started flaking heavily on the MSAN bots. Original issue's description: > Reenable WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate. > > BUG=710486 > TBR=wjmaclean@chromium.org > > Review-Url: https://codereview.chromium.org/2863633003 > Cr-Commit-Position: refs/heads/master@{#469465} > Committed: https://chromium.googlesource.com/chromium/src/+/2a3f50f3684ccd28c4eb5160909a9cb3d64c9187 TBR=paulmeyer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=710486 Review-Url: https://codereview.chromium.org/2858393004 Cr-Commit-Position: refs/heads/master@{#469623} Committed: https://chromium.googlesource.com/chromium/src/+/f92fd977be7cd346c693e88e8de19ee4e3b914b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
johnme
Created Revert of Reenable WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate.
3 years, 7 months ago (2017-05-05 10:57:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858393004/1
3 years, 7 months ago (2017-05-05 10:57:41 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 10:58:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f92fd977be7cd346c693e88e8de1...

Powered by Google App Engine
This is Rietveld 408576698