Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2858223003: Add TRACE_EVENTX() in WebAudio rendering pipe line (Closed)

Created:
3 years, 7 months ago by hongchan
Modified:
3 years, 7 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, haraken, blink-reviews, kinuko+watch, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TRACE_EVENTX() in WebAudio rendering pipe line This CL adds multiple trace events (TRACE_EVENTX) in various points in the rendering to investigate the cause of glitches. ("webaudio", "AudioDestination::Start") ("webaudio", "AudioDestination::Stop") ("webaudio", "AudioDestination::RequestRenderOnWebThread", "frames_to_render", frames_to_render) ("webaudio", "AudioDestination::Render", "callback_buffer_size", number_of_frames) ("webaudio", "AudioDestinationHandler::Render") BUG=718554 Review-Url: https://codereview.chromium.org/2858223003 Cr-Commit-Position: refs/heads/master@{#469557} Committed: https://chromium.googlesource.com/chromium/src/+/ab52b62684a4634d2d5e7fdc2a8a137af9aa8647

Patch Set 1 #

Patch Set 2 : Adjusting trace locations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDestination.cpp View 1 5 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
hongchan
PTAL.
3 years, 7 months ago (2017-05-04 22:12:02 UTC) #3
Raymond Toy
lgtm
3 years, 7 months ago (2017-05-04 23:12:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858223003/20001
3 years, 7 months ago (2017-05-04 23:17:15 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 01:06:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ab52b62684a4634d2d5e7fdc2a8a...

Powered by Google App Engine
This is Rietveld 408576698