Issue 2857983006: Allow empty UKM entries to be recorded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2857983006: Allow empty UKM entries to be recorded. (Closed)

Created:
3 years, 7 months ago by Steven Holte

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Allow empty UKM entries to be recorded. BUG=717793 Review-Url: https://codereview.chromium.org/2855053002 Cr-Commit-Position: refs/heads/master@{#469101} (cherry picked from commit 60d054d1f297debcae848680eead71f2517003fc) Review-Url: https://codereview.chromium.org/2857983006 . Cr-Commit-Position: refs/branch-heads/3071@{#406} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/c1fc814ad6f4c091de81292f9ce4c4bb8a5bf148

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -17 lines)			Patch
M	components/ukm/ukm_entry.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/ukm/ukm_entry_builder.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	components/ukm/ukm_service.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/ukm/ukm_service_unittest.cc	View	2 chunks	+2 lines, -12 lines	0 comments	Download

Total messages: 2 (1 generated)

Steven Holte

3 years, 7 months ago (2017-05-04 20:27:47 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c1fc814ad6f4c091de81292f9ce4c4bb8a5bf148.