Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2855053002: Allow empty UKM entries to be recorded. (Closed)

Created:
3 years, 7 months ago by Steven Holte
Modified:
3 years, 7 months ago
Reviewers:
rkaplow
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow empty UKM entries to be recorded. BUG=717793 Review-Url: https://codereview.chromium.org/2855053002 Cr-Commit-Position: refs/heads/master@{#469101} Committed: https://chromium.googlesource.com/chromium/src/+/60d054d1f297debcae848680eead71f2517003fc

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M components/ukm/ukm_entry.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/ukm/ukm_entry_builder.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/ukm/ukm_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ukm/ukm_service_unittest.cc View 1 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Steven Holte
3 years, 7 months ago (2017-05-03 00:00:35 UTC) #2
rkaplow
lgtm
3 years, 7 months ago (2017-05-03 13:46:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855053002/1
3 years, 7 months ago (2017-05-03 18:30:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/66221)
3 years, 7 months ago (2017-05-03 18:51:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855053002/20001
3 years, 7 months ago (2017-05-03 19:16:46 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 20:14:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/60d054d1f297debcae848680eead...

Powered by Google App Engine
This is Rietveld 408576698