Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 2857963002: Revert "[PageLoadMetrics] Keep track of Ad Sizes on Pages" (Closed)

Created:
3 years, 7 months ago by jkarlin
Modified:
3 years, 7 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, subresource-filter-reviews_chromium.org, speed-metrics-reviews_chromium.org, jam, Randy Smith (Not in Mondays), loading-reviews+metrics_chromium.org, csharrison+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, loading-reviews_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[PageLoadMetrics] Keep track of Ad Sizes on Pages" This reverts commit 6616a885b4f18edd4f6aa178146c14538ca1d429, https://codereview.chromium.org/2798953002/. We're seeing subframes created of navigations that failed to commit. TBR=bmcquade,clamy,jam,csharrison,isherman # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717892, 715547 Review-Url: https://codereview.chromium.org/2857963002 Cr-Commit-Position: refs/heads/master@{#468956} Committed: https://chromium.googlesource.com/chromium/src/+/1cf1c346b92fe3d9a5013608b88982fe99f02d60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1353 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 3 chunks +2 lines, -7 lines 0 comments Download
D chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc View 1 chunk +0 lines, -297 lines 0 comments Download
D chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc View 1 chunk +0 lines, -528 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc View 3 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc View 3 chunks +12 lines, -23 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc View 4 chunks +22 lines, -24 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_observer.h View 5 chunks +1 line, -21 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_observer.cc View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_tracker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_tracker.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M content/public/browser/resource_request_info.h View 3 chunks +0 lines, -13 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -246 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857963002/1
3 years, 7 months ago (2017-05-03 13:31:01 UTC) #8
Charlie Harrison
LGTM
3 years, 7 months ago (2017-05-03 13:32:04 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 13:32:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1cf1c346b92fe3d9a5013608b889...

Powered by Google App Engine
This is Rietveld 408576698